Refactor SegmentHolder to use SegmentConfig (instead of CollectionParams)#7098
Merged
Refactor SegmentHolder to use SegmentConfig (instead of CollectionParams)#7098
SegmentHolder to use SegmentConfig (instead of CollectionParams)#7098Conversation
782446e to
ca5f7a3
Compare
aab8f83 to
90b0545
Compare
Base automatically changed from
segment-holder-deduplicate-points-no-async
to
dev
August 20, 2025 11:26
90b0545 to
589bb21
Compare
Contributor
Author
|
Rebased on |
This comment was marked as off-topic.
This comment was marked as off-topic.
8 tasks
This was referenced Aug 20, 2025
timvisee
pushed a commit
that referenced
this pull request
Aug 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #7094. Also required for Qdrant on Edge. Removes
CollectionParamsfromSegmentHolder, so that it could be cleanly moved intoshardcrate.All Submissions:
devbranch. Did you create your branch fromdev?New Feature Submissions:
cargo +nightly fmt --allcommand prior to submission?cargo clippy --all --all-featurescommand?Changes to Core Features: