Skip to content

Refactor SegmentHolder to use SegmentConfig (instead of CollectionParams)#7098

Merged
ffuugoo merged 1 commit intodevfrom
segment-holder-no-collection-params-dep
Aug 20, 2025
Merged

Refactor SegmentHolder to use SegmentConfig (instead of CollectionParams)#7098
ffuugoo merged 1 commit intodevfrom
segment-holder-no-collection-params-dep

Conversation

@ffuugoo
Copy link
Contributor

@ffuugoo ffuugoo commented Aug 19, 2025

Based on #7094. Also required for Qdrant on Edge. Removes CollectionParams from SegmentHolder, so that it could be cleanly moved into shard crate.

All Submissions:

  • Contributions should target the dev branch. Did you create your branch from dev?
  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests?
  2. Have you formatted your code locally using cargo +nightly fmt --all command prior to submission?
  3. Have you checked your code using cargo clippy --all --all-features command?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully ran tests with your changes locally?

@ffuugoo ffuugoo added this to the Qdrant on Edge milestone Aug 19, 2025
@ffuugoo ffuugoo requested review from generall and timvisee August 19, 2025 16:38
Copy link
Member

@timvisee timvisee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice simplification 👌

@ffuugoo ffuugoo force-pushed the segment-holder-deduplicate-points-no-async branch from 782446e to ca5f7a3 Compare August 20, 2025 10:45
@ffuugoo ffuugoo force-pushed the segment-holder-no-collection-params-dep branch from aab8f83 to 90b0545 Compare August 20, 2025 10:45
Base automatically changed from segment-holder-deduplicate-points-no-async to dev August 20, 2025 11:26
@ffuugoo ffuugoo force-pushed the segment-holder-no-collection-params-dep branch from 90b0545 to 589bb21 Compare August 20, 2025 11:28
@ffuugoo ffuugoo marked this pull request as ready for review August 20, 2025 11:28
@ffuugoo
Copy link
Contributor Author

ffuugoo commented Aug 20, 2025

Rebased on dev. Will merge once green.

@coderabbitai

This comment was marked as off-topic.

coderabbitai[bot]

This comment was marked as off-topic.

@ffuugoo ffuugoo mentioned this pull request Aug 20, 2025
8 tasks
@ffuugoo ffuugoo merged commit 933c7c8 into dev Aug 20, 2025
16 checks passed
@ffuugoo ffuugoo deleted the segment-holder-no-collection-params-dep branch August 20, 2025 12:01
@coderabbitai coderabbitai bot mentioned this pull request Feb 19, 2026
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants