Remove async from SegmentHolder::deduplicate_points#7094
Merged
Conversation
async fromSegmentHolder::deduplicate_pointsasync from SegmentHolder::deduplicate_points
This comment was marked as resolved.
This comment was marked as resolved.
timvisee
approved these changes
Aug 19, 2025
lib/collection/src/collection_manager/holders/segment_holder.rs
Outdated
Show resolved
Hide resolved
generall
approved these changes
Aug 19, 2025
8 tasks
...to remove `async` from `SegmentHolder`
Rename `deduplicate_points_task` into `deduplicate_points_tasks` (plural `tasks`)
782446e to
ca5f7a3
Compare
Contributor
Author
|
Rebased on top of storage size test fix (thanks @agourlay!), will merge when green. |
8 tasks
timvisee
pushed a commit
that referenced
this pull request
Aug 26, 2025
This was referenced Mar 10, 2026
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small refactoring for Qdrant on Edge. We need to move
SegmentHolderintoshardcrate, but we don't wantasyncinshard, anddeduplicate_pointsis the onlyasyncmethod ofSegmentHolder.All Submissions:
devbranch. Did you create your branch fromdev?New Feature Submissions:
cargo +nightly fmt --allcommand prior to submission?cargo clippy --all --all-featurescommand?Changes to Core Features: