Skip to content

Remove async from SegmentHolder::deduplicate_points#7094

Merged
ffuugoo merged 2 commits intodevfrom
segment-holder-deduplicate-points-no-async
Aug 20, 2025
Merged

Remove async from SegmentHolder::deduplicate_points#7094
ffuugoo merged 2 commits intodevfrom
segment-holder-deduplicate-points-no-async

Conversation

@ffuugoo
Copy link
Contributor

@ffuugoo ffuugoo commented Aug 19, 2025

Small refactoring for Qdrant on Edge. We need to move SegmentHolder into shard crate, but we don't want async in shard, and deduplicate_points is the only async method of SegmentHolder.

All Submissions:

  • Contributions should target the dev branch. Did you create your branch from dev?
  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests?
  2. Have you formatted your code locally using cargo +nightly fmt --all command prior to submission?
  3. Have you checked your code using cargo clippy --all --all-features command?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully ran tests with your changes locally?

@ffuugoo ffuugoo changed the title Remove async fromSegmentHolder::deduplicate_points Remove async from SegmentHolder::deduplicate_points Aug 19, 2025
@ffuugoo ffuugoo requested review from generall and timvisee August 19, 2025 12:39
@ffuugoo ffuugoo added this to the Qdrant on Edge milestone Aug 19, 2025
@coderabbitai

This comment was marked as resolved.

coderabbitai[bot]

This comment was marked as resolved.

coderabbitai[bot]

This comment was marked as off-topic.

...to remove `async` from `SegmentHolder`
Rename `deduplicate_points_task` into `deduplicate_points_tasks` (plural `tasks`)
@ffuugoo ffuugoo force-pushed the segment-holder-deduplicate-points-no-async branch from 782446e to ca5f7a3 Compare August 20, 2025 10:45
@ffuugoo
Copy link
Contributor Author

ffuugoo commented Aug 20, 2025

Rebased on top of storage size test fix (thanks @agourlay!), will merge when green.

coderabbitai[bot]

This comment was marked as off-topic.

@ffuugoo ffuugoo merged commit 8a84c1a into dev Aug 20, 2025
16 checks passed
@ffuugoo ffuugoo deleted the segment-holder-deduplicate-points-no-async branch August 20, 2025 11:26
@coderabbitai coderabbitai bot mentioned this pull request Aug 21, 2025
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants