Merged
Conversation
16389a2 to
ca93538
Compare
timvisee
approved these changes
Aug 7, 2025
ca93538 to
12bdc84
Compare
This comment was marked as resolved.
This comment was marked as resolved.
timvisee
added a commit
that referenced
this pull request
Aug 11, 2025
* put all flags impls in a single module * use in appendable_dense_vector_storage * use in appendable_mmap_multi_dense_storage * use in mmap_sparse_vector_storage * clippy * Add comment we cannot rely on length of deleted vectors bitvec --------- Co-authored-by: timvisee <tim@visee.me>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To appropriately buffer writes to the deleted bitslice in the vector storages, we need to have a structure like
BitvecFlagswhich buffers updates, but also keeps a fast in-memory copy of the bitslice.In #6990 we introduced the structure. This PR does two things:
BitvecFlagswhereDynamicMmapFlagswas being used directly.