BitvecFlags: bitvec container with dynamic mmap flags storage#6990
Merged
BitvecFlags: bitvec container with dynamic mmap flags storage#6990
BitvecFlags: bitvec container with dynamic mmap flags storage#6990Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
generall
reviewed
Aug 6, 2025
generall
reviewed
Aug 6, 2025
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
timvisee
approved these changes
Aug 7, 2025
Member
timvisee
left a comment
There was a problem hiding this comment.
Looks good. Thanks!
I carefully checked the way we handle the length of structures here, as it's important for reliable iterators. While there's a bit of indirection there, everything looks sound.
timvisee
added a commit
that referenced
this pull request
Aug 11, 2025
* separate flags buffering and in-memory container * new bitvec flags * fmt * clippy * make BufferedDynamicFlags public to crate only * clear cache after loading * clippyyy * improve comment * Use resize with a constant to eliminate a hot closure * Add comment on why we take subslice of bitslice --------- Co-authored-by: timvisee <tim@visee.me>
This was referenced Nov 26, 2025
This was referenced Dec 15, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extracts the
BufferedDynamicFlagslogic into its own structure, which buffers writes and can only write to disk manually.To handle reads, two new structures have been created:
RoaringFlags: uses theBufferedDynamicFlagsas storage only, and keeps aRoaringBitmapin memory for reads.BitvecFlags: sameBufferedDynamicFlagsstorage, but with aBitVecin memory for reads.This enables the flexibility of choosing the in-memory structure. For example, vector storages need a reference to a bitslice, which can only be provided by
BitvecFlags. On the other hand, null index benefits from lower memory overhead and does not need a bitslice explicitly.