Conversation
q9f
approved these changes
Nov 5, 2025
Owner
|
I have no objections. Please either write a test for this (chatgpt is fine here) or let me know how you call or use this error code and I can see if I can add a test case myself. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #392 +/- ##
=======================================
Coverage 99.22% 99.22%
=======================================
Files 91 91
Lines 6823 6831 +8
=======================================
+ Hits 6770 6778 +8
Misses 53 53 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
@q9f Updated the PR to add tests |
ShiningRay
added a commit
to ShiningRay/eth.rb
that referenced
this pull request
Dec 24, 2025
* commit 'ab969176faf033eb0a6387b875ee3aa677c4bacf': build(deps): bump JamesIves/github-pages-deploy-action (q9f#395) build(deps): bump actions/checkout from 5 to 6 (q9f#394) add JSONRPC error code to Client::RpcError (q9f#392) Update README.md (q9f#393) build(deps): bump github/codeql-action from 3 to 4 (q9f#390) client/ws: fix client origin headers for ws requests (q9f#391) Rename websocket client to Ws and expand websocket tests (q9f#389) Add WebSocket transport to client (q9f#388) Support tuple arrays in ABI coder (q9f#387) Format EIP-4844 transaction constant (q9f#386) Fix ABI tuple handling for ethers test cases (q9f#385) Increase blob throughput limits (q9f#363) feat: use httpx for http requests (q9f#377) (q9f#382) fix: transform hash keys to strings in encoder for component type compatibility (q9f#378) fix: improve error handling for missing keys in component encoding (q9f#376) build(deps): bump actions/checkout from 4 to 5 (q9f#379) # Conflicts: # eth.gemspec # lib/eth/client/http.rb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
In the web app I'm working on I need to forward any RPC errors to the app's client as is (in JSON-RPC specified format). Having an RPC error code on the error raised by the
Clientwould make it easy. Instead, I'm currently relying on calling a bunch of private methods of the client to get the raw RPC response (certainly not ideal).If you're open to merging this in principle, please suggest the steps I need to take. Any guidance on where would you like me to put tests for this (if they are needed) is appreciated.