Skip to content

fix: transform hash keys to strings in encoder for component type compatibility#378

Merged
q9f merged 1 commit intoq9f:mainfrom
ShiningRay:transform_hash_keys
Sep 9, 2025
Merged

fix: transform hash keys to strings in encoder for component type compatibility#378
q9f merged 1 commit intoq9f:mainfrom
ShiningRay:transform_hash_keys

Conversation

@ShiningRay
Copy link
Contributor

Generally, Rubyist prefers symbolic hash keys, but in this gem we use string keys.

@codecov
Copy link

codecov bot commented Aug 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.69%. Comparing base (6b7f4a2) to head (6803785).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #378   +/-   ##
=======================================
  Coverage   99.69%   99.69%           
=======================================
  Files          89       89           
  Lines        6282     6283    +1     
=======================================
+ Hits         6263     6264    +1     
  Misses         19       19           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@q9f q9f merged commit fefb8da into q9f:main Sep 9, 2025
8 checks passed
ShiningRay added a commit to ShiningRay/eth.rb that referenced this pull request Dec 24, 2025
* commit 'ab969176faf033eb0a6387b875ee3aa677c4bacf':
  build(deps): bump JamesIves/github-pages-deploy-action (q9f#395)
  build(deps): bump actions/checkout from 5 to 6 (q9f#394)
  add JSONRPC error code to Client::RpcError (q9f#392)
  Update README.md (q9f#393)
  build(deps): bump github/codeql-action from 3 to 4 (q9f#390)
  client/ws: fix client origin headers for ws requests (q9f#391)
  Rename websocket client to Ws and expand websocket tests (q9f#389)
  Add WebSocket transport to client (q9f#388)
  Support tuple arrays in ABI coder (q9f#387)
  Format EIP-4844 transaction constant (q9f#386)
  Fix ABI tuple handling for ethers test cases (q9f#385)
  Increase blob throughput limits (q9f#363)
  feat: use httpx for http requests (q9f#377) (q9f#382)
  fix: transform hash keys to strings in encoder for component type compatibility (q9f#378)
  fix: improve error handling for missing keys in component encoding (q9f#376)
  build(deps): bump actions/checkout from 4 to 5 (q9f#379)

# Conflicts:
#	eth.gemspec
#	lib/eth/client/http.rb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants