Skip to content

Feat: Implement compute_derivative#837

Merged
banesullivan merged 11 commits intopyvista:masterfrom
jrwrigh:compute_derivative
Jul 24, 2020
Merged

Feat: Implement compute_derivative#837
banesullivan merged 11 commits intopyvista:masterfrom
jrwrigh:compute_derivative

Conversation

@jrwrigh
Copy link
Copy Markdown
Contributor

@jrwrigh jrwrigh commented Jul 14, 2020 •
edited
Loading

Overview

This PR will implement the extra quantities available for computation in vtkGradientFilter. Specifically, gradient, divergence, vorticity, and Q-criterion.

Resolves #831

Details

  • Add compute_derivative method with options for all 4 quantities in vtkGradientFilter
  • Wrap compute_gradient with compute_derivative method

TODO:

  • Implement new functionality in compute_derivative
  • Wrap compute_gradient with new function
  • Add tests
  • Update example documentation

jrwrigh
jrwrigh commented Jul 14, 2020
View reviewed changes
@jrwrigh jrwrigh changed the title WIP: Implement compute_derivative (WIP) Feat: Implement compute_derivative Jul 14, 2020
@banesullivan banesullivan added deprecation Deprecation involved. PRs that deprecate things. enhancement Changes that enhance the library labels Jul 15, 2020
banesullivan
banesullivan reviewed Jul 15, 2020
View reviewed changes
@jrwrigh jrwrigh force-pushed the compute_derivative branch from 987c2d9 to 17d6570 Compare July 15, 2020 03:05
@jrwrigh
Copy link
Copy Markdown
Contributor Author

jrwrigh commented Jul 15, 2020

@banesullivan For updating the example documentation, should I edit the python file or the ipynb?

@banesullivan
Copy link
Copy Markdown
Member

banesullivan commented Jul 16, 2020

@banesullivan For updating the example documentation, should I edit the python file or the ipynb?

The .py file. the notebooks are automatically generated.

banesullivan
banesullivan reviewed Jul 16, 2020
View reviewed changes
@banesullivan
Copy link
Copy Markdown
Member

banesullivan commented Jul 16, 2020

So far this is looking awesome! Thanks for all the hard work, @jrwrigh! Once you update that example, we're good to go!

Also, great job with the testing

@banesullivan banesullivan mentioned this pull request Jul 16, 2020
Closed
@jrwrigh jrwrigh changed the title (WIP) Feat: Implement compute_derivative Feat: Implement compute_derivative Jul 16, 2020
@jrwrigh
Copy link
Copy Markdown
Contributor Author

jrwrigh commented Jul 16, 2020

Should be good to go now.

banesullivan
banesullivan approved these changes Jul 16, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@banesullivan banesullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, LGTM and I'm happy with it. Did you grep to make sure you changed all other entries of compute_gradient -> compute_derivative?

Also, it'd be nice to update the example to show off the new features of this filter but that's not going to block this PR

@jrwrigh
Copy link
Copy Markdown
Contributor Author

jrwrigh commented Jul 16, 2020

Did you grep to make sure you changed all other entries of compute_gradient -> compute_derivative?

Just did the only remaining references are to the deprecated method and other methods keyword arguments.

it'd be nice to update the example to show off the new features of this filter.

Agreed. I was thinking about doing this, but figured I could get the feature in first before getting in the rest. I'll make an issue for it real quick (I have a question or two about it).

@jrwrigh jrwrigh mentioned this pull request Jul 16, 2020
Open
@akaszynski
Copy link
Copy Markdown
Member

akaszynski commented Jul 23, 2020

@banesullivan, I'm going to let you merge this one since you were the last one to comment on it.

@banesullivan banesullivan merged commit 617d973 into pyvista:master Jul 24, 2020
adeak added a commit to adeak/pyvista that referenced this pull request Nov 9, 2020
@adeak
Merge branch 'master' into feat/add_glyph_table
fa999fb 
* upstream/master: (37 commits)
  🔧 Fix unused variables (pyvista#847)
  Add better Unstructured Grid Documentation (pyvista#845)
  Fix typo in plotting.py (pyvista#846)
  Feat: Implement compute_derivative (pyvista#837)
  New probe filter and massively improve interpolate filter (pyvista#842)
  Clarify clip filter docstring (pyvista#840)
  Update create-structured-surface.py (pyvista#844)
  Update topo-map.py (pyvista#841)
  Add release suffix to version string (pyvista#817)
  Add pathlib Support (pyvista#836)
  Add tolerance argument to sample_over_line (pyvista#828)
  vector slice from pyvista/pyvista-support#134 (pyvista#808)
  Fix is_all_triangles (pyvista#832)
  Misc. documentation fixes (pyvista#829)
  Follow up pyvista#793: fix get_data_range (pyvista#818)
  Fix GPU info in scooby report (pyvista#825)
  Patch for auto_close warning (pyvista#798)
  Add texture demo with scalar data (pyvista#821)
  MAINT: Log init start/stop (pyvista#819)
  Add PolyData strip filter (pyvista#807)
  ...
@jrwrigh jrwrigh mentioned this pull request Aug 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@banesullivan banesullivan banesullivan approved these changes

Assignees

No one assigned

Labels

deprecation Deprecation involved. PRs that deprecate things. enhancement Changes that enhance the library

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Feature request (willing to implement): compute vorticity, divergence, etc.

3 participants

@jrwrigh @banesullivan @akaszynski