Skip to content

Add release suffix to version string#817

Merged
banesullivan merged 4 commits intomasterfrom
maint/bump-master
Jul 16, 2020
Merged

Add release suffix to version string#817
banesullivan merged 4 commits intomasterfrom
maint/bump-master

Conversation

@banesullivan
Copy link
Copy Markdown
Member

@banesullivan banesullivan commented Jun 26, 2020 •
edited
Loading

Overview

Resolve #814

Details

@banesullivan banesullivan requested a review from akaszynski June 26, 2020 16:55
@banesullivan banesullivan added the maintenance Low-impact maintenance activity label Jun 26, 2020
@akaszynski
Copy link
Copy Markdown
Member

akaszynski commented Jun 28, 2020

Actually, according to https://www.python.org/dev/peps/pep-0440/#id24, the version should be 0.26.b0

From PEP 440:

X.YaN   # Alpha release
X.YbN   # Beta release
X.YrcN  # Release Candidate
X.Y     # Final release

Let’s just change the last value of the tuple to b0. Less code to change!

akaszynski
akaszynski reviewed Jun 28, 2020
View reviewed changes
akaszynski
akaszynski reviewed Jun 28, 2020
View reviewed changes
@akaszynski
Copy link
Copy Markdown
Member

akaszynski commented Jun 28, 2020

Build is failing because this version change triggered the doc building within CI. Looks like we need better coverage...

banesullivan and others added 2 commits July 13, 2020 21:34
@banesullivan @akaszynski
Update pyvista/_version.py
781f3f0 
Co-authored-by: Alex Kaszynski <akascap@gmail.com>
@banesullivan @akaszynski
Update pyvista/_version.py
6ff9e56 
Co-authored-by: Alex Kaszynski <akascap@gmail.com>
akaszynski
akaszynski reviewed Jul 14, 2020
View reviewed changes
@banesullivan
Copy link
Copy Markdown
Member Author

banesullivan commented Jul 16, 2020

I have no idea why that test failed... it shouldn't have anything to do with this PR so I suppose we should just merge this into master. But that failing test should be investigated.

@akaszynski
Copy link
Copy Markdown
Member

akaszynski commented Jul 16, 2020

I have no idea why that test failed... it shouldn't have anything to do with this PR so I suppose we should just merge this into master. But that failing test should be investigated.

Our doc build job uses a gallery cache to avoid rebuilding the gallery. This cache is built on the first successful job based on the new version string, so each time we change the version string Azure gets a cache miss and it's rebuilt from scratch. Since the cache is only uploaded when you have a successful build, we can ensure that the build passes only when it's error free.

Looking back into the build log, I'm seeing that the docs were completely rebuilt on:
https://dev.azure.com/pyvista/PyVista/_build/results?buildId=3156&view=logs&jobId=0d0124fa-d3a8-51e8-d2f8-a0118e38d729

This PR is good go to, and the Mac fail was likely due to some bug on Azure's side. Unit tests on Mac are really slow, and I'm guessing MS is virtualizing Apple software rather than giving us "bare metal" Macs. hypothesis indicates that the test that failed was "flaky".

@banesullivan banesullivan merged commit ecbf780 into master Jul 16, 2020
@banesullivan banesullivan deleted the maint/bump-master branch July 21, 2020 20:06
adeak added a commit to adeak/pyvista that referenced this pull request Nov 9, 2020
@adeak
Merge branch 'master' into feat/add_glyph_table
fa999fb 
* upstream/master: (37 commits)
  🔧 Fix unused variables (pyvista#847)
  Add better Unstructured Grid Documentation (pyvista#845)
  Fix typo in plotting.py (pyvista#846)
  Feat: Implement compute_derivative (pyvista#837)
  New probe filter and massively improve interpolate filter (pyvista#842)
  Clarify clip filter docstring (pyvista#840)
  Update create-structured-surface.py (pyvista#844)
  Update topo-map.py (pyvista#841)
  Add release suffix to version string (pyvista#817)
  Add pathlib Support (pyvista#836)
  Add tolerance argument to sample_over_line (pyvista#828)
  vector slice from pyvista/pyvista-support#134 (pyvista#808)
  Fix is_all_triangles (pyvista#832)
  Misc. documentation fixes (pyvista#829)
  Follow up pyvista#793: fix get_data_range (pyvista#818)
  Fix GPU info in scooby report (pyvista#825)
  Patch for auto_close warning (pyvista#798)
  Add texture demo with scalar data (pyvista#821)
  MAINT: Log init start/stop (pyvista#819)
  Add PolyData strip filter (pyvista#807)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akaszynski akaszynski akaszynski approved these changes

Assignees

No one assigned

Labels

maintenance Low-impact maintenance activity

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

version on master out of sync with release

2 participants

@banesullivan @akaszynski