Skip to content

[Build] Pin cmake to build PyTorch#8902

Merged
lsy323 merged 1 commit intomasterfrom
lisyuan/pin-cmake
Mar 28, 2025
Merged

[Build] Pin cmake to build PyTorch#8902
lsy323 merged 1 commit intomasterfrom
lisyuan/pin-cmake

Conversation

@lsy323
Copy link
Copy Markdown
Collaborator

@lsy323 lsy323 commented Mar 28, 2025

Upstream build failed with latest cmake version (4.0.0) Pin the same version as upstream now pytorch/pytorch#150158

@lsy323 lsy323 marked this pull request as ready for review March 28, 2025 17:44
@lsy323 lsy323 requested review from ManfeiBai and zpcore as code owners March 28, 2025 17:44
@zpcore
Copy link
Copy Markdown
Member

zpcore commented Mar 28, 2025

Thanks for the updating! I just noticed that if we trigger the build with the branch in GCP, it will automatically show up in the CI also.

Copy link
Copy Markdown
Member

@zpcore zpcore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Let's wait for the CI.

@lsy323 lsy323 merged commit fe3bb7f into master Mar 28, 2025
20 of 22 checks passed
zpcore pushed a commit that referenced this pull request Apr 1, 2025
zpcore added a commit that referenced this pull request Apr 1, 2025
Co-authored-by: Siyuan Liu <lsiyuan@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants