Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/150158
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 67 PendingAs of commit 3f2b714 with merge base ddb1e97 ( NEW FAILURE - The following job has failed:
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
Hi @clee2000 we also found this issue on release 2.7 branch, the new cmake 4.0 release broken the build https://github.com/pytorch/pytorch/actions/runs/14118380542/job/39553773444#step:6:5464, and for linux ci build job, seems not install requirements.txt, could you please limit the cmake version <4.0 in https://github.com/pytorch/pytorch/blob/main/.ci/docker/common/install_conda.sh#L83 here also? And we need cherry-pick this fix to release/2.7 ASAP |
chuanqi129
left a comment
There was a problem hiding this comment.
please limit the cmake version <4.0 in https://github.com/pytorch/pytorch/blob/main/.ci/docker/common/install_conda.sh#L83 also
|
@pytorchbot merge -f "fixing failures" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: Approvers from one of the following sets are needed:
|
|
@pytorchbot merge -f "Abracadabra" |
|
You need to provide a reason for using force merge, in the format @pytorchbot merge -f 'Explanation'.
|
|
@pytorchbot merge -f "Bibbidi! Bobbidi... boo!" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
@pytorchbot cherry-pick --onto release/2.7 --c critical |
I'm not sure if this is the right think to do, but cmake 4.0.0 got released on pypi and our builds are failing with it Example: https://hud.pytorch.org/pytorch/pytorch/commit/aa70d62041c28fe35c416aa932b32ef0e4d5bc33#39555975425-box I guess we have to go change all the cmake_minimum_required to >=3.5? backwards compat still failing because its building with the base commit which this pr can't really change until it gets merged, but at least manywheel binary builds got past where they were originally failing Also pin the conda installation, but the most recent version on conda is 3.31.2 Pull Request resolved: #150158 Approved by: https://github.com/cyyever, https://github.com/malfet (cherry picked from commit 0ece461)
Cherry picking #150158The cherry pick PR is at #150193 and it is recommended to link a critical cherry pick PR with an issue. The following tracker issues are updated: Details for Dev Infra teamRaised by workflow job |
Pin cmake==3.31.6 (#150158) I'm not sure if this is the right think to do, but cmake 4.0.0 got released on pypi and our builds are failing with it Example: https://hud.pytorch.org/pytorch/pytorch/commit/aa70d62041c28fe35c416aa932b32ef0e4d5bc33#39555975425-box I guess we have to go change all the cmake_minimum_required to >=3.5? backwards compat still failing because its building with the base commit which this pr can't really change until it gets merged, but at least manywheel binary builds got past where they were originally failing Also pin the conda installation, but the most recent version on conda is 3.31.2 Pull Request resolved: #150158 Approved by: https://github.com/cyyever, https://github.com/malfet (cherry picked from commit 0ece461) Co-authored-by: Catherine Lee <csl@fb.com>
I'm not sure if this is the right think to do, but cmake 4.0.0 got released on pypi and our builds are failing with it Example: https://hud.pytorch.org/pytorch/pytorch/commit/aa70d62041c28fe35c416aa932b32ef0e4d5bc33#39555975425-box I guess we have to go change all the cmake_minimum_required to >=3.5? backwards compat still failing because its building with the base commit which this pr can't really change until it gets merged, but at least manywheel binary builds got past where they were originally failing Also pin the conda installation, but the most recent version on conda is 3.31.2 Pull Request resolved: pytorch#150158 Approved by: https://github.com/cyyever, https://github.com/malfet
I'm not sure if this is the right think to do, but cmake 4.0.0 got released on pypi and our builds are failing with it
Example:
https://hud.pytorch.org/pytorch/pytorch/commit/aa70d62041c28fe35c416aa932b32ef0e4d5bc33#39555975425-box
I guess we have to go change all the cmake_minimum_required to >=3.5?
backwards compat still failing because its building with the base commit which this pr can't really change until it gets merged, but at least manywheel binary builds got past where they were originally failing
Also pin the conda installation, but the most recent version on conda is 3.31.2