Pin cmake==3.31.6#150193
Merged
malfet merged 1 commit intorelease/2.7from Mar 28, 2025
Merged
Conversation
I'm not sure if this is the right think to do, but cmake 4.0.0 got released on pypi and our builds are failing with it Example: https://hud.pytorch.org/pytorch/pytorch/commit/aa70d62041c28fe35c416aa932b32ef0e4d5bc33#39555975425-box I guess we have to go change all the cmake_minimum_required to >=3.5? backwards compat still failing because its building with the base commit which this pr can't really change until it gets merged, but at least manywheel binary builds got past where they were originally failing Also pin the conda installation, but the most recent version on conda is 3.31.2 Pull Request resolved: #150158 Approved by: https://github.com/cyyever, https://github.com/malfet (cherry picked from commit 0ece461)
This was referenced Mar 28, 2025
Closed
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/150193
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
malfet
approved these changes
Mar 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure if this is the right think to do, but cmake 4.0.0 got released on pypi and our builds are failing with it
Example:
https://hud.pytorch.org/pytorch/pytorch/commit/aa70d62041c28fe35c416aa932b32ef0e4d5bc33#39555975425-box
I guess we have to go change all the cmake_minimum_required to >=3.5?
backwards compat still failing because its building with the base commit which this pr can't really change until it gets merged, but at least manywheel binary builds got past where they were originally failing
Also pin the conda installation, but the most recent version on conda is 3.31.2