Don't set $TPU_LIBRARY_PATH during import#5794
Merged
will-cromar merged 1 commit intomasterfrom Nov 14, 2023
Merged
Conversation
JackCaoG
approved these changes
Nov 13, 2023
Collaborator
JackCaoG
left a comment
There was a problem hiding this comment.
does the existing profiler test enough to cover the testing? or it has to be you manually patch and test?
Collaborator
Author
|
Our existing profiler test does not check for device traces, so I had to test manually. |
b9d868e to
a85a724
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #5698 and #5731. Once we remove
tpu_tracer(#5793), we no longer need to setTPU_LIBRARY_PATH.