[PJRT] Use TPU profiler plugin#5793
Merged
will-cromar merged 1 commit intomasterfrom Nov 14, 2023
Merged
Conversation
JackCaoG
approved these changes
Nov 13, 2023
mbzomowski
pushed a commit
to mbzomowski-test-org/xla
that referenced
this pull request
Nov 16, 2023
zpcore
pushed a commit
that referenced
this pull request
Nov 21, 2023
lsy323
pushed a commit
to lsy323/xla
that referenced
this pull request
Nov 28, 2023
chunnienc
pushed a commit
to chunnienc/xla
that referenced
this pull request
Dec 14, 2023
golechwierowicz
pushed a commit
that referenced
this pull request
Jan 12, 2024
bhavya01
pushed a commit
that referenced
this pull request
Apr 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
tpu_tracerbackend uses a static initializer that requires us to setTPU_LIBRARY_PATH, which required us to roll back #5731. Instead, use the new PJRT C API profiler extension API to register the TPU profiler.profiler::RegisterProfilerForPluginthat we can reuse for other plugins as needed. Mostly copied from JAX's pybind to do the same thing: https://github.com/openxla/xla/blob/34b419269fa7477155086730670e2aa740d80a0d/xla/python/profiler.cc#L90-L105tpu_tracerstarting a profiler sessions triggers a crash. Since the issue is (again) a static initializer, define our ownprofiler_backendstarget that excludestpu_tracerfrom the build entirely.Confirmed that TPU device traces still show up after this change.
cc @jyingl3