Revert "Don't set $TPU_LIBRARY_PATH during import (#5698)"#5731
Merged
alanwaketan merged 1 commit intomasterfrom Oct 25, 2023
Merged
Revert "Don't set $TPU_LIBRARY_PATH during import (#5698)"#5731alanwaketan merged 1 commit intomasterfrom
alanwaketan merged 1 commit intomasterfrom
Conversation
This reverts commit 146f2a0.
Collaborator
Author
No ideas... |
will-cromar
approved these changes
Oct 25, 2023
Collaborator
will-cromar
left a comment
There was a problem hiding this comment.
Do you have any more details? If the profiler depends on $TPU_LIBRARY_PATH, we should fix this upstream.
Collaborator
Author
Do you have the more details you need in the gchat? |
jonb377
pushed a commit
that referenced
this pull request
Oct 31, 2023
will-cromar
added a commit
that referenced
this pull request
Nov 13, 2023
This was referenced Nov 13, 2023
will-cromar
added a commit
that referenced
this pull request
Nov 14, 2023
mbzomowski
pushed a commit
to mbzomowski-test-org/xla
that referenced
this pull request
Nov 16, 2023
…torch#5731) This reverts commit 146f2a0.
chunnienc
pushed a commit
to chunnienc/xla
that referenced
this pull request
Dec 14, 2023
…torch#5731) This reverts commit 146f2a0.
golechwierowicz
pushed a commit
that referenced
this pull request
Jan 12, 2024
bhavya01
pushed a commit
that referenced
this pull request
Apr 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 146f2a0.
It regresses the profiler.