Removed torch.cholesky and added torch.linalg.cholesky#3274
Open
IvanYashchuk wants to merge 4 commits intopytorch:masterfrom
Open
Removed torch.cholesky and added torch.linalg.cholesky#3274IvanYashchuk wants to merge 4 commits intopytorch:masterfrom
IvanYashchuk wants to merge 4 commits intopytorch:masterfrom
Conversation
This was referenced Jan 3, 2022
Contributor
Author
Collaborator
|
@IvanYashchuk Will do today |
JackCaoG
approved these changes
Jan 28, 2022
Collaborator
JackCaoG
left a comment
There was a problem hiding this comment.
Please give me a ping before you merge the pytorch pr
bf4b7b9 to
f01f21e
Compare
clang-format-7 Try branch with linalg_qr symbol Revert "Try branch with linalg_qr symbol" This reverts commit db3e9a7. Update tensor_methods Restore formatting use tensor_methods::linalg_cholesky Remove cholesky
f01f21e to
16d12d4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
torch.choleskywas deprecated in the 1.9 release and will be removed in the next 1.11 release. This PR removescholeskyand replaces it with thelinalg_cholesky.pytorch/pytorch#70979 that removes deprecated
torch.choleskyfrom PyTorch is currently blocked by pytorch/xla.