Remove deprecated torch.cholesky#70979
Open
IvanYashchuk wants to merge 21 commits intopytorch:mainfrom
Open
Conversation
CI Flow Status⚛️ CI FlowRuleset - Version:
You can add a comment to the PR and tag @pytorchbot with the following commands: # ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun
# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slowFor more information, please take a look at the CI Flow Wiki. |
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit df7ff65 (more details on the Dr. CI page):
🕵️ 4 new failures recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
3 tasks
lezcano
approved these changes
Jan 11, 2022
| from torch.testing._internal.common_utils import \ | ||
| (TestCase, run_tests, TEST_SCIPY, IS_MACOS, IS_WINDOWS, slowTest, | ||
| TEST_WITH_ASAN, TEST_WITH_ROCM, IS_FBCODE, IS_REMOTE_GPU, | ||
| iter_indices, gradcheck, gradgradcheck, |
Collaborator
Author
|
@pytorchbot ciflow rerun |
malfet
approved these changes
Apr 5, 2023
Contributor
malfet
left a comment
There was a problem hiding this comment.
Please make sure to add this PR updates XLA submodule otherwise merge bot would refuse to merge
Contributor
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
Contributor
|
@IvanYashchuk @lezcano A question. |
Contributor
In my tests TorchFix PR to do this replacement: pytorch/test-infra#4336 |
Collaborator
|
Intially, we didn't want to have an That's the historical context of that weird flag :) |
Contributor
I see, I'll use |
Contributor
|
@lezcano |
Collaborator
|
|
Collaborator
|
ah, I see, yeah, I meant |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The time has come to remove deprecated linear algebra related functions. This PR removes torch.cholesky.
Fixes to torch/xla need to be merged before this PR:
cc @jianyuh @nikitaved @pearu @mruberry @walterddr @xwang233 @lezcano @mcarilli @ptrblck @leslie-fang-intel @jgong5 @voznesenskym @penguinwu @EikanWang @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @ngimel @yf225 @chenyang78 @soumith @yanboliang @anijain2305 @desertfire @IvanYashchuk