Removed torch.qr and added torch.linalg.qr#3273
Open
IvanYashchuk wants to merge 7 commits intopytorch:masterfrom
Open
Removed torch.qr and added torch.linalg.qr#3273IvanYashchuk wants to merge 7 commits intopytorch:masterfrom
IvanYashchuk wants to merge 7 commits intopytorch:masterfrom
Conversation
3 tasks
Collaborator
|
@IvanYashchuk head is green again, please rebase and the build should pass |
1 task
JackCaoG
requested changes
Jan 28, 2022
| @@ -852,10 +852,10 @@ TEST_F(AtenXlaTensorTest, TestQR) { | |||
| for (auto n : dims) { | |||
Collaborator
There was a problem hiding this comment.
Can we add test case to cover both complete and reduced mode?
Collaborator
|
@IvanYashchuk Is the upstream pr going to make it to the pytorch 1.11? We will do our branch cur soon too. |
Contributor
Author
|
It won't merged for 1.11 branch cut. Because of some internal issues removing of these deprecated functionality is postponed to the next 1.12 release. |
Collaborator
|
@IvanYashchuk Sounds good. We have a large pr we need to merge to pt/xla 1.10 and I was waiting for you to merge your pr first. I guess in this case I will try to merge that giant pr and it might cause some merge conflicts for you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
torch.qrwas deprecated in the 1.9 release and will be removed in the next 1.11 release. This PR removesqrand replaces it with thelinalg_qr.pytorch/pytorch#70989 that removes deprecated functions in PyTorch is currently blocked by pytorch/xla.