Skip to content

Manylinux 2.28 make sure wheels are renamed#6538

Merged
atalman merged 3 commits intopytorch:mainfrom
atalman:fix_manylinux_2_28_filename
Apr 18, 2025
Merged

Manylinux 2.28 make sure wheels are renamed#6538
atalman merged 3 commits intopytorch:mainfrom
atalman:fix_manylinux_2_28_filename

Conversation

@atalman
Copy link
Copy Markdown
Contributor

@atalman atalman commented Apr 18, 2025

Same as pytorch/pytorch#150786
Wheel filename should be:
linux_aarch64 -> manylinux_2_28_aarch64
linux_x86_64 -> manylinux_2_28_x86_64

Test in CI

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 18, 2025

@atalman is attempting to deploy a commit to the Meta Open Source Team on Vercel.

A member of the Team first needs to authorize it.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 18, 2025
@atalman atalman merged commit 45fa185 into pytorch:main Apr 18, 2025
27 of 34 checks passed
atalman added a commit to atalman/test-infra that referenced this pull request Apr 18, 2025
Same as pytorch/pytorch#150786
Wheel filename should be:
linux_aarch64 -> manylinux_2_28_aarch64
linux_x86_64 -> manylinux_2_28_x86_64

Test in CI
malfet pushed a commit that referenced this pull request Apr 18, 2025
@malfet
Copy link
Copy Markdown
Contributor

malfet commented Apr 18, 2025

Is there a followup tasks to get rid of those manual renames (i.e. wheel suffix should be properly set by bdist_wheel comand

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants