[Manylinux 2.28] Correct Linux aarch64 cuda binaries wheel name#150786
Closed
atalman wants to merge 2 commits intopytorch:mainfrom
Closed
[Manylinux 2.28] Correct Linux aarch64 cuda binaries wheel name#150786atalman wants to merge 2 commits intopytorch:mainfrom
atalman wants to merge 2 commits intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/150786
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 28 PendingAs of commit c829d90 with merge base f8b53f4 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
malfet
approved these changes
Apr 7, 2025
Contributor
malfet
left a comment
There was a problem hiding this comment.
This is probably fine, but I don't see a reason why we should not rename the wheel for CPU version as well...
Contributor
Author
|
@pytorchmergebot merge -f "lint is green and all required tests" |
Collaborator
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Contributor
Author
|
@pytorchbot cherry-pick --onto release/2.7 -c critical |
pytorchbot
pushed a commit
that referenced
this pull request
Apr 8, 2025
) Related to: #149044 (comment) For CPU binaries we run auditwheel however for cuda binaries auditwheel produces invalid results . Hence we need to rename the file. Pull Request resolved: #150786 Approved by: https://github.com/malfet (cherry picked from commit 836955b)
Collaborator
Cherry picking #150786The cherry pick PR is at #150820 and it is recommended to link a critical cherry pick PR with an issue. The following tracker issues are updated: Details for Dev Infra teamRaised by workflow job |
atalman
added a commit
that referenced
this pull request
Apr 8, 2025
) [Manylinux 2.28] Correct Linux aarch64 cuda binaries wheel name (#150786) Related to: #149044 (comment) For CPU binaries we run auditwheel however for cuda binaries auditwheel produces invalid results . Hence we need to rename the file. Pull Request resolved: #150786 Approved by: https://github.com/malfet (cherry picked from commit 836955b) Co-authored-by: atalman <atalman@fb.com>
timocafe
pushed a commit
to timocafe/pytorch
that referenced
this pull request
Apr 16, 2025
…rch#150786) Related to: pytorch#149044 (comment) For CPU binaries we run auditwheel however for cuda binaries auditwheel produces invalid results . Hence we need to rename the file. Pull Request resolved: pytorch#150786 Approved by: https://github.com/malfet
amathewc
pushed a commit
to amathewc/pytorch
that referenced
this pull request
Apr 17, 2025
…rch#150786) Related to: pytorch#149044 (comment) For CPU binaries we run auditwheel however for cuda binaries auditwheel produces invalid results . Hence we need to rename the file. Pull Request resolved: pytorch#150786 Approved by: https://github.com/malfet
This was referenced Apr 18, 2025
atalman
added a commit
to pytorch/test-infra
that referenced
this pull request
Apr 18, 2025
Same as pytorch/pytorch#150786 Wheel filename should be: linux_aarch64 -> manylinux_2_28_aarch64 linux_x86_64 -> manylinux_2_28_x86_64 Test in CI
atalman
added a commit
to atalman/test-infra
that referenced
this pull request
Apr 18, 2025
Same as pytorch/pytorch#150786 Wheel filename should be: linux_aarch64 -> manylinux_2_28_aarch64 linux_x86_64 -> manylinux_2_28_x86_64 Test in CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to: #149044 (comment)
For CPU binaries we run auditwheel however for cuda binaries auditwheel produces invalid results . Hence we need to rename the file.