Skip to content

Don't do libtorch pre-cxx11-abi for ROCm#6099

Merged
atalman merged 1 commit intomainfrom
sdym/libtorch-pre11-rocm
Dec 20, 2024
Merged

Don't do libtorch pre-cxx11-abi for ROCm#6099
atalman merged 1 commit intomainfrom
sdym/libtorch-pre11-rocm

Conversation

@kit1980
Copy link
Copy Markdown
Contributor

@kit1980 kit1980 commented Dec 20, 2024

No description provided.

@vercel
Copy link
Copy Markdown

vercel bot commented Dec 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
torchci ⬜️ Ignored (Inspect) Dec 20, 2024 8:50pm

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Dec 20, 2024

No ciflow labels are configured for this repo.
For information on how to enable CIFlow bot see this wiki

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 20, 2024
@atalman
Copy link
Copy Markdown
Contributor

atalman commented Dec 20, 2024

could you please also run ? this will update test files:

python -m tools.tests.test_generate_binary_build_matrix --update-reference-files

Copy link
Copy Markdown
Contributor

@atalman atalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@atalman atalman merged commit 70d8b87 into main Dec 20, 2024
@atalman atalman deleted the sdym/libtorch-pre11-rocm branch December 20, 2024 21:17
atalman added a commit that referenced this pull request Dec 23, 2024
Forward fix for #6099 which
removed pre-cxx-abi config for everything. Instead we skip generating it

Rocm builds pre-cxx11 removed by:
pytorch/pytorch#141423
atalman added a commit that referenced this pull request Jan 22, 2025
Forward fix for #6099 which
removed pre-cxx-abi config for everything. Instead we skip generating it

Rocm builds pre-cxx11 removed by:
pytorch/pytorch#141423
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/rocm CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: rocm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants