Upgrade ROCm wheels to manylinux2_28 - 2 of 2 (binaries)#141423
Closed
jithunnair-amd wants to merge 23 commits intopytorch:mainfrom
Closed
Upgrade ROCm wheels to manylinux2_28 - 2 of 2 (binaries)#141423jithunnair-amd wants to merge 23 commits intopytorch:mainfrom
jithunnair-amd wants to merge 23 commits intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/141423
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 Cancelled JobsAs of commit 19b6416 with merge base 6afcec0 ( CANCELLED JOBS - The following jobs were cancelled. Please retry:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
jeffdaily
approved these changes
Nov 25, 2024
jeffdaily
reviewed
Nov 25, 2024
Collaborator
Author
|
@pytorchbot rebase |
Collaborator
|
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
Collaborator
|
Successfully rebased |
508c4ad to
24e1600
Compare
d9e30bc to
f887db3
Compare
f887db3 to
15fd5d7
Compare
atalman
reviewed
Dec 3, 2024
…the PLATFORM to manylinux_2_28_x86_64
4cb5762 to
19b6416
Compare
Collaborator
Author
|
Build Triton wheels and binary manywheel jobs (including smoke tests) passed for ROCm. Merging |
Collaborator
Author
|
@pytorchbot merge -f "ROCm CI jobs passed. Unrelated CI failures" |
Collaborator
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
…er images) (pytorch#141609) Upgrade gcc version from 9 to 11 on ROCm manylinux images. Needed for pytorch#141423 since almalinux8-based manylinux2_28 images for ROCm (pytorch#140681) installs gcc-toolset-9, which installs [gcc 9.2.1](https://pkgs.org/download/gcc-toolset-9-gcc-c++). However, PyTorch CMakeLists.txt enforces a [minimum gcc version of 9.3](https://github.com/pytorch/pytorch/blob/5318bf8baf19fecda365c185cd81196e3cfb08e3/CMakeLists.txt#L61). Pull Request resolved: pytorch#141609 Approved by: https://github.com/jeffdaily Co-authored-by: Jithun Nair <jithun.nair@amd.com>
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
) Depends on pytorch#140681 and pytorch#141609 Highlights: * Upgrade binaries to ROCm6.2.4 to use latest docker images * Remove pre-cxx11 builds for libtorch on ROCm * Use manylinux2_28 docker images for ROCm * Set `DESIRED_DEVTOOLSET=cxx-abi` (and hence `_GLIBCXX_USE_CXX11_ABI=1`) for ROCm manylinux2_28 wheels (ROCm RHEL8 packages also have GCC_ABI=1, so it keeps it consistent) Pull Request resolved: pytorch#141423 Approved by: https://github.com/jeffdaily Co-authored-by: Jeff Daily <jeff.daily@amd.com> Co-authored-by: Pruthvi Madugundu <pruthvigithub@gmail.com>
This was referenced Dec 5, 2024
5 tasks
AmdSampsa
pushed a commit
to AmdSampsa/pytorch
that referenced
this pull request
Dec 9, 2024
) Depends on pytorch#140681 and pytorch#141609 Highlights: * Upgrade binaries to ROCm6.2.4 to use latest docker images * Remove pre-cxx11 builds for libtorch on ROCm * Use manylinux2_28 docker images for ROCm * Set `DESIRED_DEVTOOLSET=cxx-abi` (and hence `_GLIBCXX_USE_CXX11_ABI=1`) for ROCm manylinux2_28 wheels (ROCm RHEL8 packages also have GCC_ABI=1, so it keeps it consistent) Pull Request resolved: pytorch#141423 Approved by: https://github.com/jeffdaily Co-authored-by: Jeff Daily <jeff.daily@amd.com> Co-authored-by: Pruthvi Madugundu <pruthvigithub@gmail.com>
This was referenced Dec 23, 2024
atalman
added a commit
to pytorch/test-infra
that referenced
this pull request
Dec 23, 2024
Forward fix for #6099 which removed pre-cxx-abi config for everything. Instead we skip generating it Rocm builds pre-cxx11 removed by: pytorch/pytorch#141423
atalman
added a commit
to pytorch/test-infra
that referenced
this pull request
Jan 22, 2025
Forward fix for #6099 which removed pre-cxx-abi config for everything. Instead we skip generating it Rocm builds pre-cxx11 removed by: pytorch/pytorch#141423
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #140681 and #141609
Highlights:
DESIRED_DEVTOOLSET=cxx-abi(and hence_GLIBCXX_USE_CXX11_ABI=1) for ROCm manylinux2_28 wheels (ROCm RHEL8 packages also have GCC_ABI=1, so it keeps it consistent)cc @jeffdaily @sunway513 @pruthvistony @ROCmSupport @dllehr-amd @jataylo @hongxiayang @naromero77amd