Use cuda 12.6 wheels with Manylinux 2.28. Use Manylinux2014 for CPU, CUDA11.8, CUDA12.4#5986
Merged
Use cuda 12.6 wheels with Manylinux 2.28. Use Manylinux2014 for CPU, CUDA11.8, CUDA12.4#5986
Conversation
…CUDA11.8, CUDA12.4
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
kit1980
reviewed
Nov 26, 2024
| gpu_arch: f"pytorch/manylinux2_28-builder:cuda{gpu_arch}" | ||
| for gpu_arch in CUDA_ARCHES | ||
| }, | ||
| "11.8": f"pytorch/manylinux-builder:cuda11.8", |
huydhn
approved these changes
Nov 26, 2024
kit1980
approved these changes
Nov 26, 2024
zxiiro
approved these changes
Nov 26, 2024
malfet
approved these changes
Nov 26, 2024
Contributor
malfet
left a comment
There was a problem hiding this comment.
LGTM, but can we stop sending identical PRs against PT and than test-infra
HDCharles
added a commit
to pytorch/ao
that referenced
this pull request
Nov 27, 2024
pytorch/test-infra#5986 and pytorch/pytorch#141565 changed back to manylinux 2014 for versions of cuda/cpu, testing that this fixes the issue since hte actual error seems to be occuring in the Build the wheel step before hte post script gets run: https://github.com/pytorch/ao/actions/runs/12041427944/job/33573281510
atalman
pushed a commit
that referenced
this pull request
Nov 27, 2024
… (#5993) Also adds a way to update the files by just running the test script through `python -m tools.tests.test_generate_binary_build_matrix --update-reference-files`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PyTorch PR: https://github.com/pytorch/pytorch/pull/141565/files