Use cuda 12.6 wheels with Manylinux 2.28. Use Manylinux2014 for CPU, CUDA11.8, CUDA12.4#141565
Closed
atalman wants to merge 1 commit intopytorch:mainfrom
Closed
Use cuda 12.6 wheels with Manylinux 2.28. Use Manylinux2014 for CPU, CUDA11.8, CUDA12.4#141565atalman wants to merge 1 commit intopytorch:mainfrom
atalman wants to merge 1 commit intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/141565
Note: Links to docs will display an error until the docs builds have been completed. ❌ 18 New FailuresAs of commit 0dcd8bd with merge base 4742080 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
atalman
commented
Nov 26, 2024
| # favor of GPU_ARCH_VERSION | ||
| DESIRED_CUDA: cpu | ||
| GPU_ARCH_TYPE: cpu | ||
| DOCKER_IMAGE: pytorch/manylinux2_28-builder:cpu-main |
Contributor
Author
There was a problem hiding this comment.
I believe docker images are not used for MacOS builds. TODO: Refactor code to remove this parameter since its confusing.
5 tasks
Skylion007
approved these changes
Nov 26, 2024
huydhn
approved these changes
Nov 26, 2024
malfet
approved these changes
Nov 26, 2024
Contributor
Author
|
@pytorchmergebot merge -f "All required builds are passing and lint as well" |
Collaborator
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
HDCharles
added a commit
to pytorch/ao
that referenced
this pull request
Nov 27, 2024
pytorch/test-infra#5986 and pytorch/pytorch#141565 changed back to manylinux 2014 for versions of cuda/cpu, testing that this fixes the issue since hte actual error seems to be occuring in the Build the wheel step before hte post script gets run: https://github.com/pytorch/ao/actions/runs/12041427944/job/33573281510
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
…CUDA11.8, CUDA12.4 (pytorch#141565) For release 2.6 we will be using only CUDA 12.6 binaries on Manylinux 2.28. Issue: pytorch#123649 Pull Request resolved: pytorch#141565 Approved by: https://github.com/Skylion007, https://github.com/huydhn, https://github.com/malfet
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For release 2.6 we will be using only CUDA 12.6 binaries on Manylinux 2.28.
Issue: #123649