Conversation
This pops off refcount_, storage_, storage_offset_; there are now no more direct accesses to these fields and we can make them private (with appropriate friending).
Devirtualize functions Remove baseclass deconstructor Add _retain
Signed-off-by: Edward Z. Yang <ezyang@fb.com>
Delete nullary constructor on Tensor
Move THTensor* field to TensorImpl
Move methods from TensorDerived to TensorImpl
* Remove dim_ from THTensor * Remove context from Storage
Signed-off-by: Edward Z. Yang <ezyang@fb.com>
Signed-off-by: Edward Z. Yang <ezyang@fb.com>
Signed-off-by: Edward Z. Yang <ezyang@fb.com>
Prior to this patch, the Windows build failed saying that it ran out of heap. This fixes the problem. This is done by splitting up THTensor.cpp into more compilation units; furthermore, THTensorMath.cpp is further split into THTensorMath, THTensorMoreMath, and THTensorEvenMoreMath. Because I'm pressed for time I didn't try to split them based on theme; it's just purely positional based on the original file.
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Jul 24, 2018
Summary: Constituent PRs: - [x] #9553 Remove unnecessary functions from StorageDerived.h (by cpuhrsch, reviewed by ezyang) - [x] #9588 Use THTensor/Storage for THVoidTensor/Storage (by cpuhrsch , reviewed by gchanan) - [x] #9627 Delete context from tensor (by ezyang, reviewed by gchanan) - [x] #9641 Tensor reorganization (by ezyang, reviewed by gchanan ) - [x] #9647 Remove dim_ from THTensor (by cpuhrsch, reviewed by ezyang) - [x] #9650 Remove context (by cpuhrsch, reviewed by gchanan and ezyang) - [x] #9715 Fix Windows build in tensor merge PR (by ezyang, reviewed by gchanan and SsnL) Upcoming PRs which didn't make this cut: - [x] #9644 Stride move to TensorImpl, and nits (by ezyang, reviewed by gchanan) - [ ] #9652 Native localScalar (by ezyang, **UNREVIEWED AND FAILING TESTS**) - [x] #9710 Devirtualize TensorImpl::toString (by ezyang, reviewed by gchanan) - [ ] #9654 Use int64_t instead of ptrdiff_t for size / Rename flag to resizable_ (by cpuhrsch, **CHANGES REQUESTED AND FAILING TESTS**) Pull Request resolved: pytorch/pytorch#9713 Reviewed By: gchanan Differential Revision: D8960882 Pulled By: ezyang fbshipit-source-id: 99747b2c5462c7ff6809b67aacb4197626408204
jramseyer
pushed a commit
to jramseyer/pytorch
that referenced
this pull request
Jul 30, 2018
Summary: Constituent PRs: - [x] pytorch#9553 Remove unnecessary functions from StorageDerived.h (by cpuhrsch, reviewed by ezyang) - [x] pytorch#9588 Use THTensor/Storage for THVoidTensor/Storage (by cpuhrsch , reviewed by gchanan) - [x] pytorch#9627 Delete context from tensor (by ezyang, reviewed by gchanan) - [x] pytorch#9641 Tensor reorganization (by ezyang, reviewed by gchanan ) - [x] pytorch#9647 Remove dim_ from THTensor (by cpuhrsch, reviewed by ezyang) - [x] pytorch#9650 Remove context (by cpuhrsch, reviewed by gchanan and ezyang) - [x] pytorch#9715 Fix Windows build in tensor merge PR (by ezyang, reviewed by gchanan and SsnL) Upcoming PRs which didn't make this cut: - [x] pytorch#9644 Stride move to TensorImpl, and nits (by ezyang, reviewed by gchanan) - [ ] pytorch#9652 Native localScalar (by ezyang, **UNREVIEWED AND FAILING TESTS**) - [x] pytorch#9710 Devirtualize TensorImpl::toString (by ezyang, reviewed by gchanan) - [ ] pytorch#9654 Use int64_t instead of ptrdiff_t for size / Rename flag to resizable_ (by cpuhrsch, **CHANGES REQUESTED AND FAILING TESTS**) Pull Request resolved: pytorch#9713 Reviewed By: gchanan Differential Revision: D8960882 Pulled By: ezyang fbshipit-source-id: 99747b2c5462c7ff6809b67aacb4197626408204
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
Summary: Constituent PRs: - [x] pytorch#9553 Remove unnecessary functions from StorageDerived.h (by cpuhrsch, reviewed by ezyang) - [x] pytorch#9588 Use THTensor/Storage for THVoidTensor/Storage (by cpuhrsch , reviewed by gchanan) - [x] pytorch#9627 Delete context from tensor (by ezyang, reviewed by gchanan) - [x] pytorch#9641 Tensor reorganization (by ezyang, reviewed by gchanan ) - [x] pytorch#9647 Remove dim_ from THTensor (by cpuhrsch, reviewed by ezyang) - [x] pytorch#9650 Remove context (by cpuhrsch, reviewed by gchanan and ezyang) - [x] pytorch#9715 Fix Windows build in tensor merge PR (by ezyang, reviewed by gchanan and SsnL) Upcoming PRs which didn't make this cut: - [x] pytorch#9644 Stride move to TensorImpl, and nits (by ezyang, reviewed by gchanan) - [ ] pytorch#9652 Native localScalar (by ezyang, **UNREVIEWED AND FAILING TESTS**) - [x] pytorch#9710 Devirtualize TensorImpl::toString (by ezyang, reviewed by gchanan) - [ ] pytorch#9654 Use int64_t instead of ptrdiff_t for size / Rename flag to resizable_ (by cpuhrsch, **CHANGES REQUESTED AND FAILING TESTS**) Pull Request resolved: pytorch#9713 Reviewed By: gchanan Differential Revision: D8960882 Pulled By: ezyang fbshipit-source-id: 99747b2c5462c7ff6809b67aacb4197626408204
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Constituent PRs:
Upcoming PRs which didn't make this cut: