Use THTensor/Storage for THVoidTensor/Storage#9588
Closed
cpuhrsch wants to merge 1 commit intopytorch:masterfrom
Closed
Use THTensor/Storage for THVoidTensor/Storage#9588cpuhrsch wants to merge 1 commit intopytorch:masterfrom
cpuhrsch wants to merge 1 commit intopytorch:masterfrom
Conversation
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@cpuhrsch has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
gchanan
approved these changes
Jul 19, 2018
Contributor
gchanan
left a comment
There was a problem hiding this comment.
you could probably use THStorage / THTensor now, right? I think I used THFloatStorage at the time because we didn't have a single type yet.
Collaborator
|
remove |
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@cpuhrsch has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
This was referenced Jul 22, 2018
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 24, 2018
Summary: Constituent PRs: - [x] #9553 Remove unnecessary functions from StorageDerived.h (by cpuhrsch, reviewed by ezyang) - [x] #9588 Use THTensor/Storage for THVoidTensor/Storage (by cpuhrsch , reviewed by gchanan) - [x] #9627 Delete context from tensor (by ezyang, reviewed by gchanan) - [x] #9641 Tensor reorganization (by ezyang, reviewed by gchanan ) - [x] #9647 Remove dim_ from THTensor (by cpuhrsch, reviewed by ezyang) - [x] #9650 Remove context (by cpuhrsch, reviewed by gchanan and ezyang) - [x] #9715 Fix Windows build in tensor merge PR (by ezyang, reviewed by gchanan and SsnL) Upcoming PRs which didn't make this cut: - [x] #9644 Stride move to TensorImpl, and nits (by ezyang, reviewed by gchanan) - [ ] #9652 Native localScalar (by ezyang, **UNREVIEWED AND FAILING TESTS**) - [x] #9710 Devirtualize TensorImpl::toString (by ezyang, reviewed by gchanan) - [ ] #9654 Use int64_t instead of ptrdiff_t for size / Rename flag to resizable_ (by cpuhrsch, **CHANGES REQUESTED AND FAILING TESTS**) Pull Request resolved: #9713 Reviewed By: gchanan Differential Revision: D8960882 Pulled By: ezyang fbshipit-source-id: 99747b2c5462c7ff6809b67aacb4197626408204
jramseyer
pushed a commit
to jramseyer/pytorch
that referenced
this pull request
Jul 30, 2018
Summary: Change akin to change for THVoidStorage. Pull Request resolved: pytorch#9588 Reviewed By: gchanan Differential Revision: D8915559 Pulled By: cpuhrsch fbshipit-source-id: 6cc69df0e29942c62750f990903dfd8e4d344581
jramseyer
pushed a commit
to jramseyer/pytorch
that referenced
this pull request
Jul 30, 2018
Summary: Constituent PRs: - [x] pytorch#9553 Remove unnecessary functions from StorageDerived.h (by cpuhrsch, reviewed by ezyang) - [x] pytorch#9588 Use THTensor/Storage for THVoidTensor/Storage (by cpuhrsch , reviewed by gchanan) - [x] pytorch#9627 Delete context from tensor (by ezyang, reviewed by gchanan) - [x] pytorch#9641 Tensor reorganization (by ezyang, reviewed by gchanan ) - [x] pytorch#9647 Remove dim_ from THTensor (by cpuhrsch, reviewed by ezyang) - [x] pytorch#9650 Remove context (by cpuhrsch, reviewed by gchanan and ezyang) - [x] pytorch#9715 Fix Windows build in tensor merge PR (by ezyang, reviewed by gchanan and SsnL) Upcoming PRs which didn't make this cut: - [x] pytorch#9644 Stride move to TensorImpl, and nits (by ezyang, reviewed by gchanan) - [ ] pytorch#9652 Native localScalar (by ezyang, **UNREVIEWED AND FAILING TESTS**) - [x] pytorch#9710 Devirtualize TensorImpl::toString (by ezyang, reviewed by gchanan) - [ ] pytorch#9654 Use int64_t instead of ptrdiff_t for size / Rename flag to resizable_ (by cpuhrsch, **CHANGES REQUESTED AND FAILING TESTS**) Pull Request resolved: pytorch#9713 Reviewed By: gchanan Differential Revision: D8960882 Pulled By: ezyang fbshipit-source-id: 99747b2c5462c7ff6809b67aacb4197626408204
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
Summary: Change akin to change for THVoidStorage. Pull Request resolved: pytorch#9588 Reviewed By: gchanan Differential Revision: D8915559 Pulled By: cpuhrsch fbshipit-source-id: 6cc69df0e29942c62750f990903dfd8e4d344581
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
Summary: Constituent PRs: - [x] pytorch#9553 Remove unnecessary functions from StorageDerived.h (by cpuhrsch, reviewed by ezyang) - [x] pytorch#9588 Use THTensor/Storage for THVoidTensor/Storage (by cpuhrsch , reviewed by gchanan) - [x] pytorch#9627 Delete context from tensor (by ezyang, reviewed by gchanan) - [x] pytorch#9641 Tensor reorganization (by ezyang, reviewed by gchanan ) - [x] pytorch#9647 Remove dim_ from THTensor (by cpuhrsch, reviewed by ezyang) - [x] pytorch#9650 Remove context (by cpuhrsch, reviewed by gchanan and ezyang) - [x] pytorch#9715 Fix Windows build in tensor merge PR (by ezyang, reviewed by gchanan and SsnL) Upcoming PRs which didn't make this cut: - [x] pytorch#9644 Stride move to TensorImpl, and nits (by ezyang, reviewed by gchanan) - [ ] pytorch#9652 Native localScalar (by ezyang, **UNREVIEWED AND FAILING TESTS**) - [x] pytorch#9710 Devirtualize TensorImpl::toString (by ezyang, reviewed by gchanan) - [ ] pytorch#9654 Use int64_t instead of ptrdiff_t for size / Rename flag to resizable_ (by cpuhrsch, **CHANGES REQUESTED AND FAILING TESTS**) Pull Request resolved: pytorch#9713 Reviewed By: gchanan Differential Revision: D8960882 Pulled By: ezyang fbshipit-source-id: 99747b2c5462c7ff6809b67aacb4197626408204
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change akin to change for THVoidStorage.