Skip to content

Notify on outdated lintrunner#96241

Closed
ZainRizvi wants to merge 1 commit intomasterfrom
zainr/lint-update
Closed

Notify on outdated lintrunner#96241
ZainRizvi wants to merge 1 commit intomasterfrom
zainr/lint-update

Conversation

@ZainRizvi
Copy link
Copy Markdown
Contributor

@ZainRizvi ZainRizvi commented Mar 7, 2023 •
edited
Loading

Let users know if they have an outdated version of lintrunner installed on their box

Sets the minimum version to one which uses master as a default mergebase (see #95938)

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Mar 7, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/96241

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit e777291:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Mar 7, 2023
@ZainRizvi ZainRizvi marked this pull request as ready for review March 8, 2023 00:10
@ZainRizvi ZainRizvi requested a review from a team March 8, 2023 00:10
@ZainRizvi ZainRizvi added the ciflow/trunk Trigger trunk jobs on your pull request label Mar 8, 2023
huydhn
huydhn approved these changes Mar 8, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@huydhn huydhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ZainRizvi
Copy link
Copy Markdown
Contributor Author

ZainRizvi commented Mar 8, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Mar 8, 2023

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@ZainRizvi
Copy link
Copy Markdown
Contributor Author

ZainRizvi commented Mar 8, 2023

@pytorchbot merge -f "linter passed. Other checks are irrelevant"

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Mar 8, 2023

The merge job was canceled. If you believe this is a mistake,then you can re trigger it through pytorch-bot.

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Mar 8, 2023

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Mar 12, 2023
@ZainRizvi @cyyever
Notify on outdated lintrunner (#96241)
fd1883f 
Let users know if they have an outdated version of lintrunner installed on their box

Sets the minimum version to one which uses master as a default mergebase (see pytorch/pytorch#95938)
Pull Request resolved: pytorch/pytorch#96241
Approved by: https://github.com/huydhn
cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Mar 12, 2023
@ZainRizvi @cyyever
Notify on outdated lintrunner (#96241)
2702bf9 
Let users know if they have an outdated version of lintrunner installed on their box

Sets the minimum version to one which uses master as a default mergebase (see pytorch/pytorch#95938)
Pull Request resolved: pytorch/pytorch#96241
Approved by: https://github.com/huydhn
ydwu4 added a commit to ydwu4/pytorch that referenced this pull request Mar 13, 2023
@ydwu4
Notify on outdated lintrunner (pytorch#96241)
5e406a1 
Let users know if they have an outdated version of lintrunner installed on their box

Sets the minimum version to one which uses master as a default mergebase (see pytorch#95938)
Pull Request resolved: pytorch#96241
Approved by: https://github.com/huydhn
@ZainRizvi ZainRizvi deleted the zainr/lint-update branch April 27, 2023 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@huydhn huydhn huydhn approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ZainRizvi @pytorchmergebot @huydhn