Update lintrunner to version that uses as default mergebase by ZainRizvi · Pull Request #95938 · pytorch/pytorch

ZainRizvi · 2023-03-03T02:46:23Z

Upgrades lintrunner to the latest version which can use the master branch as the merge base by default (provided it's specified in .lintrunner.toml and update .lintrunner.toml accordingly

pytorch-bot · 2023-03-03T02:46:26Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/95938

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit f0ff6ea:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

huydhn

What's happened with everyone from 0.9.3 to 0.10.6? :P

ZainRizvi · 2023-03-03T03:10:59Z

What's happened with everyone from 0.9.3 to 0.10.6? :P

https://github.com/suo/lintrunner/blob/main/CHANGELOG.md has all the deets :)

ZainRizvi · 2023-03-03T03:14:57Z

@huy fyi, I had to update the fetch depth in .github/workflows/_calculate-docker-image.yml, since otherwise it was impossible for the calculate-docker-image action to find a merge base.

Seems like we hadn't run into this corner case in the past three weeks since docker images were added for linters

.github/workflows/_calculate-docker-image.yml

huydhn · 2023-03-03T03:21:42Z

@huy fyi, I had to update the fetch depth in .github/workflows/_calculate-docker-image.yml, since otherwise it was impossible for the calculate-docker-image action to find a merge base.

Seems like we hadn't run into this corner case in the past three weeks since docker images were added for linters

Oh I see. I'm about to ask that question. Here is what works for me in my previous PR: This step fails if the Docker image hasn't been built yet. But once the image is ready, rerunning it works.

Now I understand why some people had this step failing in their PRs and needed to rebase.

ZainRizvi · 2023-03-03T16:23:03Z

@pytorchbot rebase

pytorchmergebot · 2023-03-03T16:25:00Z

@pytorchbot successfully started a rebase job. Check the current status here

pytorchmergebot · 2023-03-03T16:25:06Z

Successfully rebased zainr/linter-update onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout zainr/linter-update && git pull --rebase)

From #95938 where a new Docker image build fails to start sccache. This issue starts to happen today (Mar 3rd). The server fails to start with a cryptic `sccache: error: Invalid argument (os error 22)` ``` =================== sccache compilation log =================== ERROR 2023-03-03T20:31:14Z: sccache::server: failed to start server: Invalid argument (os error 22) sccache: error: Invalid argument (os error 22) =========== If your build fails, please take a look at the log above for possible reasons =========== + sccache --show-stats sccache: error: Connection to server timed out ``` I don't have a good explanation for this yet. The version of sccache we build from https://github.com/pytorch/sccache is ancient. If I start to build the exact same version on Ubuntu Docker image now, the issue will manifest. But the older binary built only few days ago https://hud.pytorch.org/pytorch/pytorch/commit/e50ff3fcdb3890ce3bbab99e60b1c27ff49be2af works without any issue. So I fix sccache binary to that version instead of rebuilding it every time in the image as a temporary mitigation while trying to root cause this further. Pull Request resolved: #95997 Approved by: https://github.com/ZainRizvi

ZainRizvi · 2023-03-07T16:27:45Z

@pytorchbot rebase

pytorchmergebot · 2023-03-07T16:38:54Z

@pytorchbot successfully started a rebase job. Check the current status here

pytorchmergebot · 2023-03-07T16:39:00Z

Successfully rebased zainr/linter-update onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout zainr/linter-update && git pull --rebase)

ZainRizvi · 2023-03-07T19:42:19Z

@pytorchbot merge

pytorchmergebot · 2023-03-07T19:44:19Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

Let users know if they have an outdated version of lintrunner installed on their box Sets the minimum version to one which uses master as a default mergebase (see #95938) Pull Request resolved: #96241 Approved by: https://github.com/huydhn

From pytorch/pytorch#95938 where a new Docker image build fails to start sccache. This issue starts to happen today (Mar 3rd). The server fails to start with a cryptic `sccache: error: Invalid argument (os error 22)` ``` =================== sccache compilation log =================== ERROR 2023-03-03T20:31:14Z: sccache::server: failed to start server: Invalid argument (os error 22) sccache: error: Invalid argument (os error 22) =========== If your build fails, please take a look at the log above for possible reasons =========== + sccache --show-stats sccache: error: Connection to server timed out ``` I don't have a good explanation for this yet. The version of sccache we build from https://github.com/pytorch/sccache is ancient. If I start to build the exact same version on Ubuntu Docker image now, the issue will manifest. But the older binary built only few days ago https://hud.pytorch.org/pytorch/pytorch/commit/e50ff3fcdb3890ce3bbab99e60b1c27ff49be2af works without any issue. So I fix sccache binary to that version instead of rebuilding it every time in the image as a temporary mitigation while trying to root cause this further. Pull Request resolved: pytorch/pytorch#95997 Approved by: https://github.com/ZainRizvi

Fixes pytorch/pytorch#93156 Upgrades lintrunner to the latest version which can use the `master` branch as the merge base by default (provided it's specified in `.lintrunner.toml` and update `.lintrunner.toml` accordingly Pull Request resolved: pytorch/pytorch#95938 Approved by: https://github.com/huydhn

Let users know if they have an outdated version of lintrunner installed on their box Sets the minimum version to one which uses master as a default mergebase (see pytorch/pytorch#95938) Pull Request resolved: pytorch/pytorch#96241 Approved by: https://github.com/huydhn

From pytorch/pytorch#95938 where a new Docker image build fails to start sccache. This issue starts to happen today (Mar 3rd). The server fails to start with a cryptic `sccache: error: Invalid argument (os error 22)` ``` =================== sccache compilation log =================== ERROR 2023-03-03T20:31:14Z: sccache::server: failed to start server: Invalid argument (os error 22) sccache: error: Invalid argument (os error 22) =========== If your build fails, please take a look at the log above for possible reasons =========== + sccache --show-stats sccache: error: Connection to server timed out ``` I don't have a good explanation for this yet. The version of sccache we build from https://github.com/pytorch/sccache is ancient. If I start to build the exact same version on Ubuntu Docker image now, the issue will manifest. But the older binary built only few days ago https://hud.pytorch.org/pytorch/pytorch/commit/e50ff3fcdb3890ce3bbab99e60b1c27ff49be2af works without any issue. So I fix sccache binary to that version instead of rebuilding it every time in the image as a temporary mitigation while trying to root cause this further. Pull Request resolved: pytorch/pytorch#95997 Approved by: https://github.com/ZainRizvi

Fixes pytorch/pytorch#93156 Upgrades lintrunner to the latest version which can use the `master` branch as the merge base by default (provided it's specified in `.lintrunner.toml` and update `.lintrunner.toml` accordingly Pull Request resolved: pytorch/pytorch#95938 Approved by: https://github.com/huydhn

Let users know if they have an outdated version of lintrunner installed on their box Sets the minimum version to one which uses master as a default mergebase (see pytorch/pytorch#95938) Pull Request resolved: pytorch/pytorch#96241 Approved by: https://github.com/huydhn

From pytorch#95938 where a new Docker image build fails to start sccache. This issue starts to happen today (Mar 3rd). The server fails to start with a cryptic `sccache: error: Invalid argument (os error 22)` ``` =================== sccache compilation log =================== ERROR 2023-03-03T20:31:14Z: sccache::server: failed to start server: Invalid argument (os error 22) sccache: error: Invalid argument (os error 22) =========== If your build fails, please take a look at the log above for possible reasons =========== + sccache --show-stats sccache: error: Connection to server timed out ``` I don't have a good explanation for this yet. The version of sccache we build from https://github.com/pytorch/sccache is ancient. If I start to build the exact same version on Ubuntu Docker image now, the issue will manifest. But the older binary built only few days ago https://hud.pytorch.org/pytorch/pytorch/commit/e50ff3fcdb3890ce3bbab99e60b1c27ff49be2af works without any issue. So I fix sccache binary to that version instead of rebuilding it every time in the image as a temporary mitigation while trying to root cause this further. Pull Request resolved: pytorch#95997 Approved by: https://github.com/ZainRizvi

…95938) Fixes pytorch#93156 Upgrades lintrunner to the latest version which can use the `master` branch as the merge base by default (provided it's specified in `.lintrunner.toml` and update `.lintrunner.toml` accordingly Pull Request resolved: pytorch#95938 Approved by: https://github.com/huydhn

Let users know if they have an outdated version of lintrunner installed on their box Sets the minimum version to one which uses master as a default mergebase (see pytorch#95938) Pull Request resolved: pytorch#96241 Approved by: https://github.com/huydhn

pytorch-bot bot added the topic: not user facing topic category label Mar 3, 2023

ZainRizvi requested review from huydhn and suo March 3, 2023 02:46

ZainRizvi marked this pull request as ready for review March 3, 2023 02:46

ZainRizvi requested review from a team and jeffdaily as code owners March 3, 2023 02:46

ZainRizvi requested review from jeffdaily and removed request for jeffdaily March 3, 2023 02:47

huydhn approved these changes Mar 3, 2023

View reviewed changes

ZainRizvi added the ciflow/trunk Trigger trunk jobs on your pull request label Mar 3, 2023

huydhn reviewed Mar 3, 2023

View reviewed changes

.github/workflows/_calculate-docker-image.yml Outdated Show resolved Hide resolved

pytorchmergebot force-pushed the zainr/linter-update branch from 09083e9 to e91419c Compare March 3, 2023 16:25

ZainRizvi force-pushed the zainr/linter-update branch 2 times, most recently from 847a26f to 769d3b7 Compare March 3, 2023 17:25

huydhn mentioned this pull request Mar 3, 2023

Use working pre-built sccache binary #95997

Closed

ZainRizvi added 5 commits March 7, 2023 16:38

Update lintrunner to version that uses as default mergebase

c1f28c9

revert stuff till ci starts working

7ee098a

Bring back one lintrunner update

1d21351

Increase next pin

fc143b2

noop

f0ff6ea

pytorchmergebot force-pushed the zainr/linter-update branch from 744e809 to f0ff6ea Compare March 7, 2023 16:39

pytorchmergebot added the Merged label Mar 7, 2023

pytorchmergebot closed this in 5e73cc9 Mar 7, 2023

ZainRizvi mentioned this pull request Mar 8, 2023

Notify on outdated lintrunner #96241

Closed

ZainRizvi deleted the zainr/linter-update branch April 27, 2023 23:53

Conversation

ZainRizvi commented Mar 3, 2023

Uh oh!

pytorch-bot bot commented Mar 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/95938

✅ No Failures

Uh oh!

huydhn left a comment

Choose a reason for hiding this comment

Uh oh!

ZainRizvi commented Mar 3, 2023

Uh oh!

ZainRizvi commented Mar 3, 2023

Uh oh!

Uh oh!

huydhn commented Mar 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ZainRizvi commented Mar 3, 2023

Uh oh!

pytorchmergebot commented Mar 3, 2023

Uh oh!

pytorchmergebot commented Mar 3, 2023

Uh oh!

ZainRizvi commented Mar 7, 2023

Uh oh!

pytorchmergebot commented Mar 7, 2023

Uh oh!

pytorchmergebot commented Mar 7, 2023

Uh oh!

ZainRizvi commented Mar 7, 2023

Uh oh!

pytorchmergebot commented Mar 7, 2023

Merge started

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

pytorch-bot bot commented Mar 3, 2023 •

edited

Loading

huydhn commented Mar 3, 2023 •

edited

Loading