Simplify builtin handling of Tensor-SymNodeVariable#96044
Closed
ezyang wants to merge 3 commits intogh/ezyang/1877/basefrom
Closed
Simplify builtin handling of Tensor-SymNodeVariable#96044ezyang wants to merge 3 commits intogh/ezyang/1877/basefrom
ezyang wants to merge 3 commits intogh/ezyang/1877/basefrom
Conversation
Following CR at #95621 (comment) In fact, the block deleted is dead, because a MUST be a TensorVariable, and so it can never be a SymNodeVariable. Signed-off-by: Edward Z. Yang <ezyang@meta.com> [ghstack-poisoned]
ezyang
added a commit
that referenced
this pull request
Mar 5, 2023
Following CR at #95621 (comment) In fact, the block deleted is dead, because a MUST be a TensorVariable, and so it can never be a SymNodeVariable. Signed-off-by: Edward Z. Yang <ezyangmeta.com> ghstack-source-id: dce4fcd Pull Request resolved: #96044
Contributor
This PR needs a labelIf your changes are user facing and intended to be a part of release notes, please use a label starting with If not, please add the For more information, see |
Contributor
Author
|
This doesn't seem to work... how annoying |
Following CR at #95621 (comment) In fact, the block deleted is dead, because a MUST be a TensorVariable, and so it can never be a SymNodeVariable. Signed-off-by: Edward Z. Yang <ezyangmeta.com> cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx desertfire [ghstack-poisoned]
Following CR at #95621 (comment) In fact, the block deleted is dead, because a MUST be a TensorVariable, and so it can never be a SymNodeVariable. Signed-off-by: Edward Z. Yang <ezyangmeta.com> cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx desertfire [ghstack-poisoned]
ezyang
added a commit
that referenced
this pull request
Mar 8, 2023
Following CR at #95621 (comment) In fact, the block deleted is dead, because a MUST be a TensorVariable, and so it can never be a SymNodeVariable. Signed-off-by: Edward Z. Yang <ezyangmeta.com> ghstack-source-id: 6369791 Pull Request resolved: #96044
Chillee
approved these changes
Mar 8, 2023
Contributor
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Following CR at
#95621 (comment)
In fact, the block deleted is dead, because a MUST be a TensorVariable,
and so it can never be a SymNodeVariable.
Signed-off-by: Edward Z. Yang ezyang@meta.com
cc @soumith @voznesenskym @penguinwu @anijain2305 @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @desertfire