Skip to content

Commit 78c4f05

Browse files
ezyangezyang
committed
Update on "Simplify builtin handling of Tensor-SymNodeVariable"
Following CR at #95621 (comment) In fact, the block deleted is dead, because a MUST be a TensorVariable, and so it can never be a SymNodeVariable. Signed-off-by: Edward Z. Yang <ezyangmeta.com> cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx desertfire [ghstack-poisoned]
2 parents c3f3ad8 + 0c16503 commit 78c4f05

245 files changed

Lines changed: 6375 additions & 5084 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎.ci/docker/common/install_cache.sh‎

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -36,14 +36,11 @@ if [ -n "$ROCM_VERSION" ]; then
3636
curl --retry 3 http://repo.radeon.com/misc/.sccache_amd/sccache -o /opt/cache/bin/sccache
3737
else
3838
ID=$(grep -oP '(?<=^ID=).+' /etc/os-release | tr -d '"')
39-
case "$ID" in
40-
ubuntu)
41-
install_ubuntu
42-
;;
43-
*)
44-
install_binary
45-
;;
46-
esac
39+
# TODO: Install the pre-built binary from S3 as building from source
40+
# https://github.com/pytorch/sccache has started failing mysteriously
41+
# in which sccache server couldn't start with the following error:
42+
# sccache: error: Invalid argument (os error 22)
43+
install_binary
4744
fi
4845
chmod a+x /opt/cache/bin/sccache
4946

‎.ci/docker/requirements-ci.txt‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -244,9 +244,9 @@ unittest-xml-reporting<=3.2.0,>=2.0.0
244244
#Pinned versions:
245245
#test that import:
246246

247-
lintrunner==0.9.2
248-
#Description: all about linters
249-
#Pinned versions: 0.9.2
247+
lintrunner==0.10.7
248+
#Description: all about linters!
249+
#Pinned versions: 0.10.7
250250
#test that import:
251251

252252
rockset==1.0.3

‎.ci/pytorch/build-asan.sh‎

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,17 +14,13 @@ clang --version
1414

1515
python tools/stats/export_test_times.py
1616

17-
# detect_leaks=0: Python is very leaky, so we need suppress it
18-
# symbolize=1: Gives us much better errors when things go wrong
19-
export ASAN_OPTIONS=detect_leaks=0:detect_stack_use_after_return=1:symbolize=1:detect_odr_violation=0
2017
if [ -n "$(which conda)" ]; then
2118
export CMAKE_PREFIX_PATH=/opt/conda
2219
fi
2320

24-
# TODO: Make the ASAN flags a centralized env var and unify with USE_ASAN option
2521
CC="clang" CXX="clang++" LDSHARED="clang --shared" \
26-
CFLAGS="-fsanitize=address -fsanitize=undefined -fno-sanitize-recover=all -fsanitize-address-use-after-scope -shared-libasan" \
2722
USE_ASAN=1 USE_CUDA=0 USE_MKLDNN=0 \
23+
UBSAN_FLAGS="-fno-sanitize-recover=all" \
2824
python setup.py bdist_wheel
2925
pip_install_whl "$(echo dist/*.whl)"
3026

‎.ci/pytorch/build-tsan.sh‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ if [ -n "$(which conda)" ]; then
1919
fi
2020

2121
CC="clang" CXX="clang++" LDSHARED="clang --shared" \
22-
CFLAGS="-fsanitize=thread" \
2322
USE_TSAN=1 USE_CUDA=0 USE_MKLDNN=0 \
2423
python setup.py bdist_wheel
2524
pip_install_whl "$(echo dist/*.whl)"

‎.ci/pytorch/common_utils.sh‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -149,6 +149,14 @@ function clone_pytorch_xla() {
149149
fi
150150
}
151151

152+
function install_matplotlib() {
153+
pip_install matplotlib
154+
}
155+
156+
function install_tabulate() {
157+
pip_install tabulate
158+
}
159+
152160
function setup_torchdeploy_deps(){
153161
conda install -y -n "py_${ANACONDA_PYTHON_VERSION}" "libpython-static=${ANACONDA_PYTHON_VERSION}"
154162
local CC

0 commit comments

Comments
 (0)