Skip to content

Enable Python dispatcher on inference-only aot_dispatch_base#94118

Closed
ezyang wants to merge 1 commit intogh/ezyang/1780/basefrom
gh/ezyang/1780/head
Closed

Enable Python dispatcher on inference-only aot_dispatch_base#94118
ezyang wants to merge 1 commit intogh/ezyang/1780/basefrom
gh/ezyang/1780/head

Conversation

@ezyang
Copy link
Copy Markdown
Contributor

@ezyang ezyang commented Feb 4, 2023

Stack from ghstack (oldest at bottom):

Signed-off-by: Edward Z. Yang ezyang@meta.com

Signed-off-by: Edward Z. Yang <ezyang@meta.com>

[ghstack-poisoned]
@ezyang ezyang requested a review from Chillee as a code owner February 4, 2023 02:57
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Feb 4, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/94118

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 2 Pending

As of commit d2a72cc:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

ezyang added a commit that referenced this pull request Feb 4, 2023
Signed-off-by: Edward Z. Yang <ezyangmeta.com>

ghstack-source-id: 464dcb4
Pull Request resolved: #94118
@ezyang ezyang added release notes: composability release notes category topic: bug fixes topic category labels Feb 4, 2023
@ezyang
Copy link
Copy Markdown
Contributor Author

ezyang commented Feb 4, 2023

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Feb 4, 2023
@pytorchmergebot
Copy link
Copy Markdown
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

seemethere added a commit that referenced this pull request Feb 7, 2023
Had to provide a merge conflict resolution due to conflicts with #94118

This reverts commit a71395d.
pytorchmergebot pushed a commit that referenced this pull request Feb 7, 2023
…" (#94329)

Had to provide a merge conflict resolution due to conflicts with #94118

This was causing issues with internal tests that look similar to:
```
in clone_preserve_strides
    x.size(), x.stride(), x.storage_offset()
AttributeError: 'KeyedJaggedTensor' object has no attribute 'size'
```

See https://fburl.com/testinfra/nc0du2sp for more information

This reverts commit #90150

@jansel can you help @blzheng with re-landing this as a co-development diff?

Pull Request resolved: #94329
Approved by: https://github.com/jansel
@facebook-github-bot facebook-github-bot deleted the gh/ezyang/1780/head branch June 8, 2023 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: AO frontend release notes: composability release notes category topic: bug fixes topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants