Skip to content

Revert "[inductor] fix crash issue when input is a view tensor (#90150)"#94329

Closed
seemethere wants to merge 1 commit intomasterfrom
seemethere/revert_90150
Closed

Revert "[inductor] fix crash issue when input is a view tensor (#90150)"#94329
seemethere wants to merge 1 commit intomasterfrom
seemethere/revert_90150

Conversation

@seemethere
Copy link
Copy Markdown
Member

@seemethere seemethere commented Feb 7, 2023 •
edited
Loading

Had to provide a merge conflict resolution due to conflicts with #94118

This was causing issues with internal tests that look similar to:

in clone_preserve_strides
    x.size(), x.stride(), x.storage_offset()
AttributeError: 'KeyedJaggedTensor' object has no attribute 'size'

See https://fburl.com/testinfra/nc0du2sp for more information

Appears as though this is an issue with torchrec's KeyedJaggedTensor implementation not having a size attribute. (https://github.com/pytorch/torchrec/blob/3138495d1b3a6d3cdb0561c802f2a3994dd3d24e/torchrec/sparse/jagged_tensor.py#L682), cc @colin2328 as a torchrec representative to help with this

This reverts commit #90150

@jansel can you help @blzheng with re-landing this as a co-development diff?

cc @mlazos @soumith @voznesenskym @yanboliang @penguinwu @anijain2305 @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @peterbell10 @desertfire

@seemethere
Revert "[inductor] fix crash issue when input is a view tensor (#90150)"
d6b123c 
Had to provide a merge conflict resolution due to conflicts with #94118

This reverts commit a71395d.
@seemethere seemethere requested review from blzheng and ezyang February 7, 2023 20:08
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Feb 7, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/94329

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit d6b123c:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Feb 7, 2023

@seemethere has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@seemethere seemethere requested a review from jansel February 7, 2023 20:08
@seemethere
Copy link
Copy Markdown
Member Author

seemethere commented Feb 7, 2023

@pytorchbot merge -f"Revert was found to fix issues, going to force merge"

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Feb 7, 2023

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@seemethere seemethere mentioned this pull request Feb 7, 2023
Closed
@github-actions github-actions bot deleted the seemethere/revert_90150 branch August 9, 2024 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jansel jansel jansel approved these changes

@ezyang ezyang Awaiting requested review from ezyang

@blzheng blzheng Awaiting requested review from blzheng

Assignees

No one assigned

Labels

ciflow/inductor Merged module: dynamo module: inductor release notes: AO frontend

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@seemethere @facebook-github-bot @pytorchmergebot @jansel