Skip to content

Add fabi-version=11 to ensure compatibility between gcc7 and gcc9 binaries for _GLIBCXX_USE_CXX11_ABI=1#93835

Closed
zhuhong61 wants to merge 1 commit intopytorch:mainfrom
zhuhong61:zh/gabi_cxx11_abi
Closed

Add fabi-version=11 to ensure compatibility between gcc7 and gcc9 binaries for _GLIBCXX_USE_CXX11_ABI=1#93835
zhuhong61 wants to merge 1 commit intopytorch:mainfrom
zhuhong61:zh/gabi_cxx11_abi

Conversation

@zhuhong61
Copy link
Copy Markdown
Contributor

@zhuhong61 zhuhong61 commented Feb 1, 2023

Fixes ##92550

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Feb 1, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/93835

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Failures

As of commit 8931c07:

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Feb 1, 2023
@zhuhong61 zhuhong61 force-pushed the zh/gabi_cxx11_abi branch 2 times, most recently from b957bef to ce36efc Compare February 3, 2023 07:47
@bdhirsh bdhirsh requested a review from malfet February 6, 2023 14:13
@bdhirsh bdhirsh added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Feb 6, 2023
malfet
malfet approved these changes Feb 6, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, though why this is still necessary? We should be building everything with g++9, as gcc-7 is not C++17 compliant

@malfet
Copy link
Copy Markdown
Contributor

malfet commented Feb 6, 2023

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Feb 6, 2023
@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Feb 6, 2023

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Feb 6, 2023

Merge failed

Reason: 1 mandatory check(s) failed (Rule superuser). The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

@zhuhong61
Copy link
Copy Markdown
Contributor Author

zhuhong61 commented Feb 6, 2023 •
edited
Loading

Sure, though why this is still necessary? We should be building everything with g++9, as gcc-7 is not C++17 compliant

Hi @malfet Because the cxx11_abi=1 wheel test will be blocked by this check: https://github.com/pytorch/builder/blob/main/check_binary.sh#L440. We got _cxxabi1013, not _cxxabi1011.
So we add fabi-version=11 for the compatibility. Do you have any suggestions to fix this check failure?

@zhuhong61
Copy link
Copy Markdown
Contributor Author

zhuhong61 commented Feb 6, 2023

By the way, we have picked these changes into #79409.

@malfet
Copy link
Copy Markdown
Contributor

malfet commented Feb 6, 2023

By the way, we have picked these changes into #79409.

I've noticed that and imho this is not a very good practice.

@malfet
Copy link
Copy Markdown
Contributor

malfet commented Feb 7, 2023

@pytorchbot merge -f "XLA failures are unrelated"

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Feb 7, 2023

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@JackCaoG
Copy link
Copy Markdown
Collaborator

JackCaoG commented Feb 7, 2023

@malfet This pr is breaking pytorch/xla build, can we revert and investigate tmr?

@JackCaoG
Copy link
Copy Markdown
Collaborator

JackCaoG commented Feb 7, 2023

I think currently on CI we enable the ABI, the failure is when we try to build pytorch, it doesn't even get to the pytorch/xla. It seems like we are the only CI that runs on clang-8.

@huydhn
Copy link
Copy Markdown
Contributor

huydhn commented Feb 7, 2023

@pytorchbot revert -m 'This breaks XLA build https://hud.pytorch.org/pytorch/pytorch/commit/b562be793a7f9fa8923b09367c320b1c378f6d25' -c ignoredsignal

@huydhn huydhn reopened this Feb 7, 2023
@JackCaoG
Copy link
Copy Markdown
Collaborator

JackCaoG commented Feb 7, 2023

Thanks @huydhn !

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Feb 7, 2023

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Feb 7, 2023

@zhuhong61 your PR has been successfully reverted.

pytorchmergebot added a commit that referenced this pull request Feb 7, 2023
@pytorchmergebot
Revert "Add fabi-version=11 to ensure compatibility between gcc7 and …
1063394 
…gcc9 binaries for _GLIBCXX_USE_CXX11_ABI=1 (#93835)"

This reverts commit b562be7.

Reverted #93835 on behalf of https://github.com/huydhn due to This breaks XLA build https://hud.pytorch.org/pytorch/pytorch/commit/b562be793a7f9fa8923b09367c320b1c378f6d25
@malfet
Copy link
Copy Markdown
Contributor

malfet commented Feb 9, 2023

@malfet This pr is breaking pytorch/xla build, can we revert and investigate tmr?

Sorry about the regression

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 10, 2023

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions bot added the Stale label Apr 10, 2023
@github-actions github-actions bot closed this May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@malfet malfet malfet approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged open source Reverted Stale topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@zhuhong61 @malfet @pytorchmergebot @JackCaoG @huydhn @bdhirsh @pytorchbot