Add new checks in CI system to verify the built linux pip wheel with cpu-cxx11-abi#79409
Add new checks in CI system to verify the built linux pip wheel with cpu-cxx11-abi#79409zhuhong61 wants to merge 1 commit intopytorch:masterfrom
Conversation
🔗 Helpful links
❌ 5 New Failures, 3 PendingAs of commit 30c8a2e (more details on the Dr. CI page): Expand to see more
🕵️ 5 new failures recognized by patternsThe following CI failures do not appear to be due to upstream breakages
|
|
Hi @malfet, any comment for this? This PR is for pytorch/builder#990 (comment), thanks! |
|
Hi @malfet |
|
@zhuhong61 please rebase, otherwise looks good to me |
|
@malfet Rebase finished. Thanks! |
malfet
left a comment
There was a problem hiding this comment.
It could not go until pytorch/builder#1062 is re-landed, is it?
Thanks @malfet When conda wheel pytorch/builder#1062 is ready, I will add checks in ci system for it separately. |
@malfet This one is ready to merge. Pls help review. |
|
Can we validate that it is compatible with manylinux_2_28? |
@malfet ,Thanks for your reply. We have validated the pip wheel built with cpu-cxx11-abi in manylinux_2_28 (x86_64 image: quay.io/pypa/manylinux_2_28_x86_64 https://github.com/pypa/manylinux), and it is compatible with manylinux_2_28.
|
|
Hi @malfet Any comments? Thanks! |
|
@malfet |
|
/easycla As part of the transition to the PyTorch Foundation, this project now requires contributions be covered under the new CLA. See #85559 for additional details. This comment will trigger a new check of this PR. If you are already covered, you will simply see a new "EasyCLA" check that passes. If you are not covered, a bot will leave a new comment with a link to sign. |
|
|
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/79409
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 6c72bcb: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
@malfet Thanks for reply. To solve or bypass the ABI issue, I think we have 3 options as below.
For #1, it should be a perfect solution, but with PyTorch API changes, which will pollute ecosystem, as well? For #3, @fzhao3 proposed a great idea, that, only provide a release build package on download server in a separate folder, instead of official release path? Could you consider this option? Thanks. |
|
@fzhao3 @gujinghui some concerns regarding publishing new binary:
|
|
@pytorchbot rebase |
|
@pytorchbot successfully started a rebase job. Check the current status here |
|
Successfully rebased |
d3bc80e to
25a7b7a
Compare
|
To fix the failure in xla build as below, we reverted the change in CMakeLists.txt. Could you please review and merge the PR pytorch/builder#1303 ? |
|
@pytorchbot rebase |
|
@pytorchbot successfully started a rebase job. Check the current status here |
|
Successfully rebased |
7952422 to
d2264e0
Compare
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
@pytorchbot rebase |
|
@pytorchbot successfully started a rebase job. Check the current status here |
|
Successfully rebased |
2637ff7 to
e0d408c
Compare
Merge failedReason: New commits were pushed while merging. Please rerun the merge command. Details for Dev Infra teamRaised by workflow job |
…cpu-cxx11-abi Co-authored-by: Zhu Hong <hong.zhu@intel.com> Co-authored-by: Guo Yejun <yejun.guo@intel.com>
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
We added the linux pip wheel with cpu-cxx11-abi in pytorch/builder, see: pytorch/builder#990 and pytorch/builder#1023
The purpose of this PR is to add new checks in pytorch CI system to verify the linux pip wheel with cpu-cxx11-abi.
Co-authored-by: Zhu Hong hong.zhu@intel.com
Co-authored-by: Guo Yejun yejun.guo@intel.com
cc @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10