Fix CUDA build failures#9347
Closed
mingzhe09088 wants to merge 1 commit intopytorch:masterfrom
mingzhe09088:fix-cuda-build
Closed
Fix CUDA build failures#9347mingzhe09088 wants to merge 1 commit intopytorch:masterfrom mingzhe09088:fix-cuda-build
mingzhe09088 wants to merge 1 commit intopytorch:masterfrom
mingzhe09088:fix-cuda-build
Conversation
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@mingzhe09088 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
orionr
approved these changes
Jul 11, 2018
| -Wno-shadow | ||
| -Wsign-promo | ||
| -Wstrict-overflow=5 | ||
| -Wno-strict-overflow |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Jul 11, 2018
Summary: Breaking this out of #8338 This fixes some CUDA related build and runtime issues after BUILD_CAFFE2 and BUILD_ATEN are removed. cc orionr Pull Request resolved: pytorch/pytorch#9347 Reviewed By: orionr Differential Revision: D8806954 Pulled By: mingzhe09088 fbshipit-source-id: 9f8e3feee06478d1ac2deb30796939453352d388
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Jul 13, 2018
Summary: Breaking this out of #8338 This fixes some CUDA related build and runtime issues after BUILD_CAFFE2 and BUILD_ATEN are removed. cc orionr Pull Request resolved: pytorch/pytorch#9347 Reviewed By: orionr Differential Revision: D8806954 Pulled By: mingzhe09088 fbshipit-source-id: 9f8e3feee06478d1ac2deb30796939453352d388
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
Summary: Breaking this out of pytorch#8338 This fixes some CUDA related build and runtime issues after BUILD_CAFFE2 and BUILD_ATEN are removed. cc orionr Pull Request resolved: pytorch#9347 Reviewed By: orionr Differential Revision: D8806954 Pulled By: mingzhe09088 fbshipit-source-id: 9f8e3feee06478d1ac2deb30796939453352d388
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking this out of #8338
This fixes some CUDA related build and runtime issues after BUILD_CAFFE2 and BUILD_ATEN are removed.
cc @orionr