[build] Remove BUILD_CAFFE2 and build everything#8338
[build] Remove BUILD_CAFFE2 and build everything#8338orionr wants to merge 30 commits intopytorch:masterfrom
Conversation
CMakeLists.txt
Outdated
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
There's a lot of reindenting going on in this diff, which makes it hard to tell what the changes are. With my code reviewer hat on, it's super helpful if there is a changelog enumerating what the substantive changes to the cmake are. It helps a lot when doing review, since I know what to be looking for. |
|
@ezyang most of the changes are basically removing the if(BUILD_ATEN) or if(BUILD_CAFFE2) blocks, hence lots of indentation. |
945f7a0 to
d968f6c
Compare
|
@ezyang, when we've fixed all the build failures and done more than just indenting / |
c3d3163 to
31ef861
Compare
8b8d6ce to
7ee09ad
Compare
|
@pytorchbot retest this please |
fd63c2c to
ff4a418
Compare
|
@ezyang "There's a lot of reindenting going on in this diff, which makes it hard to tell what the changes are." - take a look at the "Hide whitespace changes" checkbox under "Diff settings" at the top of the diff. It's analogous to |
|
@pytorchbot retest this please |
This reverts commit 017e7ac6f9ee4eaa006205f42339c1233c3eecd4.
facebook-github-bot
left a comment
There was a problem hiding this comment.
orionr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
This completely removes BUILD_CAFFE2 from CMake. There is still a little bit of "full build" stuff in setup.py that enables USE_CUDNN and BUILD_PYTHON, but otherwise everything should be enabled for PyTorch as well as Caffe2. This gets us a lot closer to full unification.
cc @mingzhe09088, @pjh5, @ezyang, @smessmer, @Yangqing