Fix Android build issue#9275
Closed
mingzhe09088 wants to merge 1 commit intopytorch:masterfrom
mingzhe09088:fix-android-build-issue
Closed
Fix Android build issue#9275mingzhe09088 wants to merge 1 commit intopytorch:masterfrom mingzhe09088:fix-android-build-issue
mingzhe09088 wants to merge 1 commit intopytorch:masterfrom
mingzhe09088:fix-android-build-issue
Conversation
orionr
approved these changes
Jul 9, 2018
Contributor
orionr
left a comment
There was a problem hiding this comment.
We probably need to see what's not supported in ATen in the Android case, but that can be deferred until later. Thanks for this!
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@mingzhe09088 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Jul 9, 2018
Summary: Breaking this out of #8338 This fixed an Android build issue after BUILD_CAFFE2 and BUILD_ATEN are removed. cc orionr Pull Request resolved: pytorch/pytorch#9275 Reviewed By: orionr Differential Revision: D8769913 Pulled By: mingzhe09088 fbshipit-source-id: afce52a12697757a0b2103c7c343e19ab158a9f7
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Jul 13, 2018
Summary: Breaking this out of #8338 This fixed an Android build issue after BUILD_CAFFE2 and BUILD_ATEN are removed. cc orionr Pull Request resolved: pytorch/pytorch#9275 Reviewed By: orionr Differential Revision: D8769913 Pulled By: mingzhe09088 fbshipit-source-id: afce52a12697757a0b2103c7c343e19ab158a9f7
Contributor
|
This PR seems somewhat questionable. ANDROID builds should be done with a working cross compiler, so there doesn't seem anything wrong with the test in question? That being said, I don't think we should be in the business of making ATen build on Android... |
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
Summary: Breaking this out of pytorch#8338 This fixed an Android build issue after BUILD_CAFFE2 and BUILD_ATEN are removed. cc orionr Pull Request resolved: pytorch#9275 Reviewed By: orionr Differential Revision: D8769913 Pulled By: mingzhe09088 fbshipit-source-id: afce52a12697757a0b2103c7c343e19ab158a9f7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking this out of #8338
This fixed an Android build issue after BUILD_CAFFE2 and BUILD_ATEN are removed.
cc @orionr