Fix Eigen issue on OS X with CUDA and nvcc compile#9270
Closed
orionr wants to merge 1 commit intopytorch:masterfrom
Closed
Fix Eigen issue on OS X with CUDA and nvcc compile#9270orionr wants to merge 1 commit intopytorch:masterfrom
orionr wants to merge 1 commit intopytorch:masterfrom
Conversation
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@orionr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
Author
|
Manual run of the Android test passed at https://ci.pytorch.org/jenkins/job/caffe2-builds/job/py2-android-ubuntu16.04-build/9231/console so going to declare victory on the tests here. |
xiaomengy
approved these changes
Jul 9, 2018
Contributor
xiaomengy
left a comment
There was a problem hiding this comment.
Please make sure the failed test are not related to this change.
Contributor
|
@pytorchbot retest this please |
Contributor
Author
|
@BIT-silence - yup, test failures are not related, although a retest never hurts. I am seeing internal test failures, so working through those. |
orionr
added a commit
to orionr/pytorch
that referenced
this pull request
Jul 11, 2018
Summary: Pull Request resolved: pytorch#9350 Re-apply pytorch#9270 Breaking this out of pytorch#8338 This takes care of the Eigen failure we saw on Mac CUDA builds when BUILD_CAFFE2 and BUILD_ATEN were removed. Fix is to isolate Eigen from headers included by cu files and processed by nvcc. This was worked on with smessmer. Differential Revision: D8794431 fbshipit-source-id: 7877732bbbc1d3ffa918938aaccf7eddfae394df
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 11, 2018
Summary: Pull Request resolved: #9350 Re-apply #9270 Breaking this out of #8338 This takes care of the Eigen failure we saw on Mac CUDA builds when BUILD_CAFFE2 and BUILD_ATEN were removed. Fix is to isolate Eigen from headers included by cu files and processed by nvcc. This was worked on with smessmer. Reviewed By: mingzhe09088 Differential Revision: D8794431 fbshipit-source-id: de656334af46c697802073f8e8d9a6aeb9ca65a7
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
Summary: Breaking this out of pytorch#8338 This takes care of the Eigen failure we saw on Mac CUDA builds when BUILD_CAFFE2 and BUILD_ATEN were removed. Fix is to isolate Eigen from headers included by cu files and processed by nvcc. This was worked on with smessmer. cc mingzhe09088 smessmer BIT-silence Yangqing Pull Request resolved: pytorch#9270 Reviewed By: mingzhe09088 Differential Revision: D8768025 Pulled By: orionr fbshipit-source-id: 5b34017aeb67e35a1b5938d962181ccd4cd37591
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
Summary: Pull Request resolved: pytorch#9350 Re-apply pytorch#9270 Breaking this out of pytorch#8338 This takes care of the Eigen failure we saw on Mac CUDA builds when BUILD_CAFFE2 and BUILD_ATEN were removed. Fix is to isolate Eigen from headers included by cu files and processed by nvcc. This was worked on with smessmer. Reviewed By: mingzhe09088 Differential Revision: D8794431 fbshipit-source-id: de656334af46c697802073f8e8d9a6aeb9ca65a7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking this out of #8338
This takes care of the Eigen failure we saw on Mac CUDA builds when BUILD_CAFFE2 and BUILD_ATEN were removed. Fix is to isolate Eigen from headers included by cu files and processed by nvcc. This was worked on with @smessmer.
cc @mingzhe09088 @smessmer @BIT-silence @Yangqing