Skip to content

COO intersection kernel: respect value intersection order#92242

Closed
nikitaved wants to merge 49 commits intogh/nikitaved/14/basefrom
gh/nikitaved/14/head
Closed

COO intersection kernel: respect value intersection order#92242
nikitaved wants to merge 49 commits intogh/nikitaved/14/basefrom
gh/nikitaved/14/head

Conversation

@nikitaved
Copy link
Copy Markdown
Collaborator

@nikitaved nikitaved commented Jan 16, 2023 •
edited
Loading

@nikitaved nikitaved mentioned this pull request Jan 16, 2023
Closed
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Jan 16, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/92242

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 185f532:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@nikitaved nikitaved mentioned this pull request Jan 16, 2023
Closed
@pytorch-bot pytorch-bot bot added the release notes: sparse release notes category label Jan 16, 2023
This was referenced Jan 16, 2023
Closed
Closed
@nikitaved nikitaved mentioned this pull request Jan 16, 2023
Closed
@nikitaved nikitaved requested a review from cpuhrsch January 23, 2023 09:29
nikitaved added a commit that referenced this pull request Jan 23, 2023
@nikitaved
COO intersection kernel: respect value intersection order
45b93f0 
ghstack-source-id: 36344c8
Pull Request resolved: #92242
@nikitaved
Copy link
Copy Markdown
Collaborator Author

nikitaved commented Jan 24, 2023 •
edited
Loading

@cpuhrsch , @amjames , @pearu , could you please stamp this one?

@nikitaved nikitaved requested review from amjames and pearu January 24, 2023 11:17
@nikitaved
Copy link
Copy Markdown
Collaborator Author

nikitaved commented Feb 7, 2023

@pytorchbot merge -g

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Feb 7, 2023
@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Feb 7, 2023

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@jeanschmidt
Copy link
Copy Markdown
Contributor

jeanschmidt commented Feb 9, 2023

This commit is breaking VS17 builds, I am not able to get the specific error. Please reach out to Skotch Vail or Andrew Krieger for more details.

@jeanschmidt
Copy link
Copy Markdown
Contributor

jeanschmidt commented Feb 9, 2023

@pytorchbot revert -m "breaking vs17" -c nosignal

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Feb 9, 2023

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Feb 9, 2023

@nikitaved your PR has been successfully reverted.

pytorchmergebot added a commit that referenced this pull request Feb 9, 2023
@pytorchmergebot
Revert "COO intersection kernel: respect value intersection order (#9…
76ed1a8 
…2242)"

This reverts commit b07c839.

Reverted #92242 on behalf of https://github.com/jeanschmidt due to breaking vs17
@nikitaved nikitaved reopened this Feb 9, 2023
@nikitaved
Copy link
Copy Markdown
Collaborator Author

nikitaved commented Feb 9, 2023 •
edited
Loading

@jeanschmidt , looks like MSVC is having hard times with cpp17 I guess? And/or structured binding from a tuple... Otherwise the code change is trivial.

@jeanschmidt
Copy link
Copy Markdown
Contributor

jeanschmidt commented Feb 9, 2023

Yeah, by reading the code I can't figure out why this is causing the mentioned build errors. This change is trivial and should pass. I hope that you get the support to isolate the issue from the approvers and the names I mentioned.

There is a taskforce ongoing to check if we need to include VS17 on our CI jobs or we can fully ditch its support.

pearu
pearu approved these changes Feb 9, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@pearu pearu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a question but LGTM!

@nikitaved
Copy link
Copy Markdown
Collaborator Author

nikitaved commented Feb 14, 2023

Closing, it is obsolete.

@nikitaved nikitaved closed this Feb 14, 2023
@facebook-github-bot facebook-github-bot deleted the gh/nikitaved/14/head branch June 8, 2023 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pearu pearu pearu approved these changes

@cpuhrsch cpuhrsch cpuhrsch approved these changes

@amjames amjames amjames approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: sparse release notes category Reverted

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@nikitaved @pytorchmergebot @jeanschmidt @pearu @cpuhrsch @amjames @pytorchbot