Skip to content

Add platform markers for linux x86_64 only extra_install_requires#91083

Closed
TimeRainStarSky wants to merge 0 commit intopytorch:masterfrom
TimeRainStarSky:master
Closed

Add platform markers for linux x86_64 only extra_install_requires#91083
TimeRainStarSky wants to merge 0 commit intopytorch:masterfrom
TimeRainStarSky:master

Conversation

@TimeRainStarSky
Copy link
Copy Markdown
Contributor

@TimeRainStarSky TimeRainStarSky commented Dec 19, 2022

Like #89924

#85097 added new extra dependencies on nvidia-*. They are linux x86_64 (GPU) only packages, but were not marked as such, causing issues installing pytorch 1.13 via Poetry (and possibly other tools that follow PyPI's metadata API) on Linux aarch64 systems. This "fixes" the issue by adding the ; platform_machine == 'x86_64' marker on these dependencies.

@TimeRainStarSky TimeRainStarSky requested a review from a team as a code owner December 19, 2022 04:19
@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Dec 19, 2022
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Dec 19, 2022 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/91083

Note: Links to docs will display an error until the docs builds have been completed.

❌ 19 Failures

As of commit 5e9fa0a:

BROKEN TRUNK - The following jobs failed but were present on the merge base 5e9fa0a:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla bot commented Dec 19, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: TimeRainStarSky / name: 时雨◎星空 (bd8d4f8)

@huydhn huydhn added ciflow/trunk Trigger trunk jobs on your pull request ciflow/binaries Trigger all binary build and upload jobs on the PR test-config/default labels Dec 20, 2022
@ZainRizvi
Copy link
Copy Markdown
Contributor

ZainRizvi commented Dec 20, 2022

Please take a look at the failing workflows:

Building wheel torch-2.0.0.dev20221220+cu117-with-pypi-cudnn
pytorch_extra_install_requirements: nvidia-cuda-runtime-cu11; platform_system == 'Linux'; platform_machine == 'x86_64' | nvidia-cudnn-cu11==8.5.0.96; platform_system == 'Linux'; platform_machine == 'x86_64' | nvidia-cublas-cu11==11.10.3.66; platform_system == 'Linux'; platform_machine == 'x86_64'
error in torch setup command: 'install_requires' must be a string or list of strings containing valid project/version requirement specifiers; Parse error at "'; platfo'": Expected stringEnd

@huydhn huydhn mentioned this pull request Dec 21, 2022
Closed
@ngimel ngimel added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Dec 21, 2022
lawrenceong
lawrenceong reviewed Jan 9, 2023
View reviewed changes
.github/scripts/generate_binary_build_matrix.py Outdated
"nvidia-cuda-runtime-cu11; platform_system == 'Linux' | "
"nvidia-cudnn-cu11==8.5.0.96; platform_system == 'Linux' | "
"nvidia-cublas-cu11==11.10.3.66; platform_system == 'Linux'",
"nvidia-cuda-runtime-cu11; platform_system == 'Linux'; platform_machine == 'x86_64' | "
Copy link
Copy Markdown

@lawrenceong lawrenceong Jan 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably this:

Suggested change
"nvidia-cuda-runtime-cu11; platform_system == 'Linux'; platform_machine == 'x86_64' | "
"nvidia-cuda-runtime-cu11; platform_system == 'Linux' and platform_machine == 'x86_64' | "

@I-love-study I-love-study mentioned this pull request Jan 17, 2023
Closed
@TimeRainStarSky TimeRainStarSky mentioned this pull request Jan 26, 2023
Closed
pytorchmergebot pushed a commit that referenced this pull request Jan 31, 2023
@TimeRainStarSky @pytorchmergebot
Add platform markers for linux x86_64 only extra_install_requires (#9…
b179a09 
…3066)

Like #89924 #91083

#85097 added new extra dependencies on nvidia-*. They are linux x86_64 (GPU) only packages, but were not marked as such, causing issues installing pytorch 1.13 via Poetry (and possibly other tools that follow PyPI's metadata API) on Linux aarch64 systems. This "fixes" the issue by adding the `and platform_machine == 'x86_64'` marker on these dependencies.

Pull Request resolved: #93066
Approved by: https://github.com/malfet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@lawrenceong lawrenceong lawrenceong left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ciflow/binaries Trigger all binary build and upload jobs on the PR ciflow/trunk Trigger trunk jobs on your pull request open source test-config/default topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@TimeRainStarSky @ZainRizvi @lawrenceong @huydhn @ngimel @pytorchbot