Add platform markers for linux x86_64 only extra_install_requires#93066
Closed
TimeRainStarSky wants to merge 1 commit intopytorch:masterfrom
Closed
Add platform markers for linux x86_64 only extra_install_requires#93066TimeRainStarSky wants to merge 1 commit intopytorch:masterfrom
TimeRainStarSky wants to merge 1 commit intopytorch:masterfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/93066
Note: Links to docs will display an error until the docs builds have been completed. ❌ 7 FailuresAs of commit 9d7afa1: NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following jobs failed but were present on the merge base 5e9fa0a:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Collaborator
|
The fix sounds good. I'll let Infra team review the full change. |
malfet
approved these changes
Jan 27, 2023
Contributor
malfet
left a comment
There was a problem hiding this comment.
Looks good to me, if it passes binary builds
Contributor
|
@pytorchbot merge -f "binary builds are green" |
Collaborator
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Like #89924 #91083
#85097 added new extra dependencies on nvidia-*. They are linux x86_64 (GPU) only packages, but were not marked as such, causing issues installing pytorch 1.13 via Poetry (and possibly other tools that follow PyPI's metadata API) on Linux aarch64 systems. This "fixes" the issue by adding the
and platform_machine == 'x86_64'marker on these dependencies.cc @malfet