Build Windows binaries with Visual Studio 2022 Build Tools#90855
Closed
Blackhex wants to merge 1 commit intopytorch:masterfrom
Closed
Build Windows binaries with Visual Studio 2022 Build Tools#90855Blackhex wants to merge 1 commit intopytorch:masterfrom
Blackhex wants to merge 1 commit intopytorch:masterfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/90855
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 3 PendingAs of commit c758715: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
2c11621 to
e1e807d
Compare
8e18f2e to
f4ee44f
Compare
9e20a01 to
087e290
Compare
0116b0d to
16b26bc
Compare
16b26bc to
8d93d3b
Compare
jeanschmidt
approved these changes
Feb 7, 2023
Contributor
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Collaborator
Merge failedReason: This PR is too stale; the last push date was more than 3 days ago. Please rebase and try again. You can rebase by leaving the following comment on this PR: Details for Dev Infra teamRaised by workflow job |
Contributor
|
@pytorchbot rebase |
8d93d3b to
c758715
Compare
Collaborator
|
@pytorchbot successfully started a rebase job. Check the current status here |
Collaborator
|
Tried to rebase and push PR #90855, but it was already up to date |
seemethere
approved these changes
Feb 7, 2023
Member
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
huydhn
added a commit
to huydhn/pytorch
that referenced
this pull request
Apr 20, 2023
…ytorch#90855)" This reverts commit a88c15a.
pytorchmergebot
pushed a commit
that referenced
this pull request
Apr 20, 2023
…90855) (#99591) This reverts commit a88c15a. Once we have the AMI ready, we can revert this and use VS2022 again. This is to mitigate flaky Windows build in trunk pytorch/builder#1387. Note that as VS2019 is already available in the current AMI, it won't be installed again per logic in https://github.com/pytorch/builder/blob/main/windows/internal/vs2019_install.ps1#L25-L29. Thus, this helps avoid the flaky installation issue. Pull Request resolved: #99591 Approved by: https://github.com/kit1980, https://github.com/Blackhex, https://github.com/malfet
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables VS 2022 binaries for build and test jobs. Another PR pytorch/builder#1240 is doing majority of the work.
Closes #87695.
cc @peterjc123 @mszhanyi @skyline75489 @nbcsm @seemethere @malfet @pytorch/pytorch-dev-infra