Skip to content

Revert "Build Windows binaries with Visual Studio 2022 Build Tools (#90855)#99591

Closed
huydhn wants to merge 2 commits intopytorch:mainfrom
huydhn:use-vs2019-windows-build
Closed

Revert "Build Windows binaries with Visual Studio 2022 Build Tools (#90855)#99591
huydhn wants to merge 2 commits intopytorch:mainfrom
huydhn:use-vs2019-windows-build

Conversation

@huydhn
Copy link
Copy Markdown
Contributor

@huydhn huydhn commented Apr 20, 2023 •
edited
Loading

This reverts commit a88c15a. Once we have the AMI ready, we can revert this and use VS2022 again. This is to mitigate flaky Windows build in trunk pytorch/builder#1387.

Note that as VS2019 is already available in the current AMI, it won't be installed again per logic in https://github.com/pytorch/builder/blob/main/windows/internal/vs2019_install.ps1#L25-L29. Thus, this helps avoid the flaky installation issue.

@huydhn huydhn added ciflow/binaries Trigger all binary build and upload jobs on the PR test-config/default labels Apr 20, 2023
@huydhn huydhn requested review from a team, Blackhex and malfet April 20, 2023 02:20
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Apr 20, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/99591

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 99762d3:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Apr 20, 2023
@huydhn huydhn requested a review from kit1980 April 20, 2023 02:31
@huydhn
Copy link
Copy Markdown
Contributor Author

huydhn commented Apr 20, 2023

Confirm that VS2019 installation is short-circuited by the AMI, so this would work:

C:\actions-runner\_work\pytorch\pytorch\builder>if "2019" == "2019" powershell windows/internal/vs2019_install.ps1 
Refreshing environment variables from the registry for powershell.exe. Please wait...
Finished
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100 1375k  100 1375k    0     0  23.9M      0 --:--:-- --:--:-- --:--:-- 24.4M
Found correctly versioned existing BuildTools installation in C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Apr 20, 2023
@pytorch pytorch deleted a comment from pytorchmergebot Apr 20, 2023
@huydhn
Copy link
Copy Markdown
Contributor Author

huydhn commented Apr 20, 2023

@pytorchbot merge -f 'Binary build jobs have passed. No need to wait for trunk'

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Apr 20, 2023

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Blackhex Blackhex Blackhex approved these changes

@malfet malfet malfet approved these changes

+1 more reviewer

@kit1980 kit1980 kit1980 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ciflow/binaries Trigger all binary build and upload jobs on the PR ciflow/trunk Trigger trunk jobs on your pull request Merged test-config/default topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@huydhn @pytorchmergebot @Blackhex @kit1980 @malfet