[multipy] Address GetPythonFramesFunction() and multipy incompatibility. (#267)#89315
Closed
PaliC wants to merge 1 commit intopytorch:masterfrom
Closed
[multipy] Address GetPythonFramesFunction() and multipy incompatibility. (#267)#89315PaliC wants to merge 1 commit intopytorch:masterfrom
PaliC wants to merge 1 commit intopytorch:masterfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/89315
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit f18c0cf: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D41414263 |
1f7e101 to
d5ca39c
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D41414263 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D41414263 |
d5ca39c to
17295a5
Compare
kurman
approved these changes
Nov 24, 2022
Contributor
kurman
left a comment
There was a problem hiding this comment.
Stamping to unblock fixes.
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D41414263 |
17295a5 to
6355b6d
Compare
PaliC
added a commit
to PaliC/pytorch
that referenced
this pull request
Nov 24, 2022
…ty. (pytorch#89315) Summary: Pull Request resolved: pytorch#89315 X-link: meta-pytorch/multipy#267 pytorch#89122 introduces internal compatibility issues with torchdeploy. However, GetPythonFramesFunction() never worked with torchdeploy, so this PR simply reverts to the original behavior of skipping the function if torchdeploy is used as a forward fix. Test Plan: Running failed tests in T128123281 ``` buck2 test @//mode/opt //multipy/runtime:test_deploy -- --exact 'multipy/runtime:test_deploy - TorchpyTest.TaggingRace' --run-disabled buck2 test mode/dev //multipy/runtime/testdev:test_deploy_from_python -- --exact 'multipy/runtime/testdev:test_deploy_from_python - multipy.runtime.testdev.test_deploy_from_python.TestDeployFromPython: test_deploy_from_python' ``` Reviewed By: kurman Differential Revision: D41414263 fbshipit-source-id: 504b704a283ca168f460c5346be1bcc6bc03d6c9
6355b6d to
f21537c
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D41414263 |
Contributor
|
@PaliC has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D41414263 |
f21537c to
d765b31
Compare
d765b31 to
45ffc73
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D41414263 |
…ty. (pytorch#267) (pytorch#89315) Summary: pytorch#89122 introduces internal compatibility issues with torchdeploy. However, GetPythonFramesFunction() never worked with torchdeploy, so this PR simply reverts to the original behavior of skipping the function if torchdeploy is used as a forward fix. Pull Request resolved: pytorch#89315 Test Plan: Running failed tests in T128123281 ``` buck2 test @//mode/opt //multipy/runtime:test_deploy -- --exact 'multipy/runtime:test_deploy - TorchpyTest.TaggingRace' --run-disabled buck2 test mode/dev //multipy/runtime/testdev:test_deploy_from_python -- --exact 'multipy/runtime/testdev:test_deploy_from_python - multipy.runtime.testdev.test_deploy_from_python.TestDeployFromPython: test_deploy_from_python' ``` Reviewed By: kurman Differential Revision: D41414263 Pulled By: PaliC fbshipit-source-id: 045f71bda7293e1505e98d6102a6aead05d1b851
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D41414263 |
45ffc73 to
f18c0cf
Compare
Contributor
|
@PaliC has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
kulinseth
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Dec 10, 2022
…ty. (#267) (pytorch#89315) Summary: pytorch#89122 introduces internal compatibility issues with torchdeploy. However, GetPythonFramesFunction() never worked with torchdeploy, so this PR simply reverts to the original behavior of skipping the function if torchdeploy is used as a forward fix. Test Plan: Running failed tests in T128123281 ``` buck2 test @//mode/opt //multipy/runtime:test_deploy -- --exact 'multipy/runtime:test_deploy - TorchpyTest.TaggingRace' --run-disabled buck2 test mode/dev //multipy/runtime/testdev:test_deploy_from_python -- --exact 'multipy/runtime/testdev:test_deploy_from_python - multipy.runtime.testdev.test_deploy_from_python.TestDeployFromPython: test_deploy_from_python' ``` Differential Revision: D41414263 Pull Request resolved: pytorch#89315 Approved by: https://github.com/kurman
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 25, 2026
…ty. (pytorch#267) (pytorch#89315) Summary: pytorch#89122 introduces internal compatibility issues with torchdeploy. However, GetPythonFramesFunction() never worked with torchdeploy, so this PR simply reverts to the original behavior of skipping the function if torchdeploy is used as a forward fix. Test Plan: Running failed tests in T128123281 ``` buck2 test @//mode/opt //multipy/runtime:test_deploy -- --exact 'multipy/runtime:test_deploy - TorchpyTest.TaggingRace' --run-disabled buck2 test mode/dev //multipy/runtime/testdev:test_deploy_from_python -- --exact 'multipy/runtime/testdev:test_deploy_from_python - multipy.runtime.testdev.test_deploy_from_python.TestDeployFromPython: test_deploy_from_python' ``` Differential Revision: D41414263 Pull Request resolved: pytorch#89315 Approved by: https://github.com/kurman
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
#89122 introduces internal compatibility issues with torchdeploy. However, GetPythonFramesFunction() never worked with torchdeploy, so this PR simply reverts to the original behavior of skipping the function if torchdeploy is used as a forward fix.
Test Plan:
Running failed tests in T128123281
Differential Revision: D41414263