[LTC] Restore GetPythonFrames#89122
Closed
alanwaketan wants to merge 10 commits intomasterfrom
Closed
Conversation
Summary: 936e930 delete the registration of GetPythonFramesFunction. Restore that and add a test case to prevent regression. Test Plan: python test/lazy/test_debug_util.py
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/89122
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 FailuresAs of commit bea0d69: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Collaborator
Author
|
@pytorchbot merge -g |
Collaborator
Merge startedYour change will be merged once all checks on your PR pass since you used the green (-g) flag (ETA: 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Collaborator
Merge failedReason: 2 additional jobs have failed, first few of them are: trunk ,trunk / macos-12-py3-x86-64 / test (default, 2, 2, macos-12) Details for Dev Infra teamRaised by workflow job |
Collaborator
Author
|
@pytorchbot merge -f "macos error shouldn't be related" |
Collaborator
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
PaliC
added a commit
to PaliC/multipy
that referenced
this pull request
Nov 18, 2022
Summary: pytorch/pytorch#89122 introduces internal compatibility issues with torchdeploy. However, GetPythonFramesFunction() never worked with torchdeploy, so this PR simply reverts to the original behavior of skipping the function if torchdeploy is used as a forward fix. Differential Revision: D41414263 fbshipit-source-id: f9f90948175b4f689a9a58b98c37225f57b47674
PaliC
added a commit
to PaliC/pytorch
that referenced
this pull request
Nov 24, 2022
…ty. (pytorch#89315) Summary: Pull Request resolved: pytorch#89315 X-link: meta-pytorch/multipy#267 pytorch#89122 introduces internal compatibility issues with torchdeploy. However, GetPythonFramesFunction() never worked with torchdeploy, so this PR simply reverts to the original behavior of skipping the function if torchdeploy is used as a forward fix. Test Plan: Running failed tests in T128123281 ``` buck2 test @//mode/opt //multipy/runtime:test_deploy -- --exact 'multipy/runtime:test_deploy - TorchpyTest.TaggingRace' --run-disabled buck2 test mode/dev //multipy/runtime/testdev:test_deploy_from_python -- --exact 'multipy/runtime/testdev:test_deploy_from_python - multipy.runtime.testdev.test_deploy_from_python.TestDeployFromPython: test_deploy_from_python' ``` Reviewed By: kurman Differential Revision: D41414263 fbshipit-source-id: 504b704a283ca168f460c5346be1bcc6bc03d6c9
PaliC
added a commit
to PaliC/pytorch
that referenced
this pull request
Nov 24, 2022
…ty. (pytorch#267) (pytorch#89315) Summary: pytorch#89122 introduces internal compatibility issues with torchdeploy. However, GetPythonFramesFunction() never worked with torchdeploy, so this PR simply reverts to the original behavior of skipping the function if torchdeploy is used as a forward fix. Pull Request resolved: pytorch#89315 Test Plan: Running failed tests in T128123281 ``` buck2 test @//mode/opt //multipy/runtime:test_deploy -- --exact 'multipy/runtime:test_deploy - TorchpyTest.TaggingRace' --run-disabled buck2 test mode/dev //multipy/runtime/testdev:test_deploy_from_python -- --exact 'multipy/runtime/testdev:test_deploy_from_python - multipy.runtime.testdev.test_deploy_from_python.TestDeployFromPython: test_deploy_from_python' ``` Reviewed By: kurman Differential Revision: D41414263 Pulled By: PaliC fbshipit-source-id: 045f71bda7293e1505e98d6102a6aead05d1b851
pytorchmergebot
pushed a commit
that referenced
this pull request
Nov 28, 2022
…ty. (#267) (#89315) Summary: #89122 introduces internal compatibility issues with torchdeploy. However, GetPythonFramesFunction() never worked with torchdeploy, so this PR simply reverts to the original behavior of skipping the function if torchdeploy is used as a forward fix. Test Plan: Running failed tests in T128123281 ``` buck2 test @//mode/opt //multipy/runtime:test_deploy -- --exact 'multipy/runtime:test_deploy - TorchpyTest.TaggingRace' --run-disabled buck2 test mode/dev //multipy/runtime/testdev:test_deploy_from_python -- --exact 'multipy/runtime/testdev:test_deploy_from_python - multipy.runtime.testdev.test_deploy_from_python.TestDeployFromPython: test_deploy_from_python' ``` Differential Revision: D41414263 Pull Request resolved: #89315 Approved by: https://github.com/kurman
kulinseth
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Dec 10, 2022
Summary: pytorch/pytorch@936e930 delete the registration of GetPythonFramesFunction. Restore that and add a test case to prevent regression. Test Plan: python test/lazy/test_debug_util.py Fixes pytorch/xla#4206. Pull Request resolved: pytorch#89122 Approved by: https://github.com/JackCaoG
kulinseth
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Dec 10, 2022
…ty. (#267) (pytorch#89315) Summary: pytorch#89122 introduces internal compatibility issues with torchdeploy. However, GetPythonFramesFunction() never worked with torchdeploy, so this PR simply reverts to the original behavior of skipping the function if torchdeploy is used as a forward fix. Test Plan: Running failed tests in T128123281 ``` buck2 test @//mode/opt //multipy/runtime:test_deploy -- --exact 'multipy/runtime:test_deploy - TorchpyTest.TaggingRace' --run-disabled buck2 test mode/dev //multipy/runtime/testdev:test_deploy_from_python -- --exact 'multipy/runtime/testdev:test_deploy_from_python - multipy.runtime.testdev.test_deploy_from_python.TestDeployFromPython: test_deploy_from_python' ``` Differential Revision: D41414263 Pull Request resolved: pytorch#89315 Approved by: https://github.com/kurman
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 25, 2026
Summary: pytorch/pytorch@67eabf2 delete the registration of GetPythonFramesFunction. Restore that and add a test case to prevent regression. Test Plan: python test/lazy/test_debug_util.py Fixes pytorch/xla#4206. Pull Request resolved: pytorch#89122 Approved by: https://github.com/JackCaoG
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 25, 2026
…ty. (pytorch#267) (pytorch#89315) Summary: pytorch#89122 introduces internal compatibility issues with torchdeploy. However, GetPythonFramesFunction() never worked with torchdeploy, so this PR simply reverts to the original behavior of skipping the function if torchdeploy is used as a forward fix. Test Plan: Running failed tests in T128123281 ``` buck2 test @//mode/opt //multipy/runtime:test_deploy -- --exact 'multipy/runtime:test_deploy - TorchpyTest.TaggingRace' --run-disabled buck2 test mode/dev //multipy/runtime/testdev:test_deploy_from_python -- --exact 'multipy/runtime/testdev:test_deploy_from_python - multipy.runtime.testdev.test_deploy_from_python.TestDeployFromPython: test_deploy_from_python' ``` Differential Revision: D41414263 Pull Request resolved: pytorch#89315 Approved by: https://github.com/kurman
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
936e930 delete the registration of GetPythonFramesFunction. Restore that and add a test case to prevent regression.
Test Plan:
python test/lazy/test_debug_util.py
Fixes pytorch/xla#4206.