Skip to content

Uses cuda pypi nccl#88125

Closed
syed-ahmed wants to merge 7 commits intopytorch:masterfrom
syed-ahmed:pypi-nccl
Closed

Uses cuda pypi nccl#88125
syed-ahmed wants to merge 7 commits intopytorch:masterfrom
syed-ahmed:pypi-nccl

Conversation

@syed-ahmed
Copy link
Copy Markdown
Collaborator

@syed-ahmed syed-ahmed commented Oct 31, 2022

This PR adds NCCL from pypi as a dependency. See pytorch/builder#1196 for testing plan.

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Oct 31, 2022

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/88125

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 58cb9cb:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Oct 31, 2022
@syed-ahmed syed-ahmed marked this pull request as ready for review October 31, 2022 21:42
@syed-ahmed syed-ahmed requested a review from a team as a code owner October 31, 2022 21:42
@syed-ahmed syed-ahmed marked this pull request as draft November 1, 2022 18:50
Copy link
Copy Markdown
Contributor

@atalman atalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Syed! Please see comments below.

@syed-ahmed syed-ahmed marked this pull request as ready for review November 21, 2022 20:16
@syed-ahmed syed-ahmed requested a review from atalman November 21, 2022 20:22
@zou3519 zou3519 added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Nov 28, 2022
@atalman atalman added the ciflow/binaries_wheel Trigger binary build and upload jobs for wheel on the PR label Nov 28, 2022
@atalman
Copy link
Copy Markdown
Contributor

atalman commented Nov 28, 2022

@pytorchbot -help

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Nov 28, 2022

❌ 🤖 pytorchbot command failed:

@pytorchbot: error: argument -h/--help: ignored explicit argument 'elp'

usage: @pytorchbot [-h] {merge,revert,rebase,label,drci} ...

Try @pytorchbot --help for more info.

@atalman
Copy link
Copy Markdown
Contributor

atalman commented Nov 28, 2022

@pytorchbot --help

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Nov 28, 2022

PyTorchBot Help

usage: @pytorchbot [-h] {merge,revert,rebase,label,drci} ...

In order to invoke the bot on your PR, include a line that starts with
@pytorchbot anywhere in a comment. That line will form the command; no
multi-line commands are allowed. 

Example:
    Some extra context, blah blah, wow this PR looks awesome

    @pytorchbot merge

optional arguments:
  -h, --help            Show this help message and exit.

command:
  {merge,revert,rebase,label,drci}
    merge               Merge a PR
    revert              Revert a PR
    rebase              Rebase a PR
    label               Add label to a PR
    drci                Update Dr. CI

Merge

usage: @pytorchbot merge [-g | -f MESSAGE | -l] [-r [{viable/strict,master}]]

Merge an accepted PR, subject to the rules in .github/merge_rules.json.
By default, this will wait for all required checks (lint, pull) to succeed before merging.

optional arguments:
  -g, --green           Merge when all status checks running on the PR pass. To add status checks, use labels like `ciflow/trunk`.
  -f MESSAGE, --force MESSAGE
                        Merge without checking anything. This requires a reason for auditting purpose, for example:
                        @pytorchbot merge -f 'Minor update to fix lint. Expecting all PR tests to pass'
  -l, --land-checks     [Deprecated - your PR instead now gets the `ciflow/trunk` label on approval] Merge with land time checks. This will create a new branch with your changes rebased on viable/strict and run a majority of trunk tests _before_ landing to increase trunk reliability and decrease risk of revert. The tests added are: pull, Lint and trunk. Note that periodic is excluded.
  -r [{viable/strict,master}], --rebase [{viable/strict,master}]
                        Rebase the PR to re run checks before merging.  Accepts viable/strict or master as branch options and will default to viable/strict if not specified.

Revert

usage: @pytorchbot revert -m MESSAGE -c
                          {nosignal,ignoredsignal,landrace,weird,ghfirst}

Revert a merged PR. This requires that you are a Meta employee.

Example:
  @pytorchbot revert -m="This is breaking tests on trunk. hud.pytorch.org/" -c=nosignal

optional arguments:
  -m MESSAGE, --message MESSAGE
                        The reason you are reverting, will be put in the commit message. Must be longer than 3 words.
  -c {nosignal,ignoredsignal,landrace,weird,ghfirst}, --classification {nosignal,ignoredsignal,landrace,weird,ghfirst}
                        A machine-friendly classification of the revert reason.

Rebase

usage: @pytorchbot rebase [-s | -b BRANCH]

Rebase a PR. Rebasing defaults to the stable viable/strict branch of pytorch.
You, along with any member of the pytorch organization, can rebase your PR.

optional arguments:
  -s, --stable          [DEPRECATED] Rebase onto viable/strict
  -b BRANCH, --branch BRANCH
                        Branch you would like to rebase to

Label

usage: @pytorchbot label labels [labels ...]

Adds label to a PR

positional arguments:
  labels  Labels to add to given Pull Request

Dr CI

usage: @pytorchbot drci

Update Dr. CI. Updates the Dr. CI comment on the PR in case it's gotten out of sync with actual CI results.

@syed-ahmed
Copy link
Copy Markdown
Collaborator Author

Merged this PR here: #89944. Closing.

@syed-ahmed syed-ahmed closed this Dec 2, 2022
syed-ahmed added a commit to syed-ahmed/pytorch that referenced this pull request Dec 5, 2022
syed-ahmed added a commit to syed-ahmed/pytorch that referenced this pull request Dec 16, 2022
syed-ahmed added a commit to syed-ahmed/pytorch that referenced this pull request Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/binaries_wheel Trigger binary build and upload jobs for wheel on the PR open source topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants