Skip to content

Adds more nvidia pypi dependencies#89944

Closed
syed-ahmed wants to merge 4 commits intopytorch:masterfrom
syed-ahmed:pypi-cufft
Closed

Adds more nvidia pypi dependencies#89944
syed-ahmed wants to merge 4 commits intopytorch:masterfrom
syed-ahmed:pypi-cufft

Conversation

@syed-ahmed
Copy link
Copy Markdown
Collaborator

@syed-ahmed syed-ahmed commented Nov 30, 2022 •
edited
Loading

This PR adds more nvidia pypi dependencies for cuda 11.7 wheel. Additionally, it pins cufft version to 10.9.0.58 to resolve #88038

Depends on: pytorch/builder#1196

cc: @malfet @atalman @ptrblck

@syed-ahmed syed-ahmed requested a review from a team as a code owner November 30, 2022 19:15
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Nov 30, 2022 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/89944

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit ed682c3:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Nov 30, 2022
@drisspg drisspg requested a review from malfet December 1, 2022 17:32
@drisspg drisspg added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Dec 1, 2022
@syed-ahmed
Copy link
Copy Markdown
Collaborator Author

syed-ahmed commented Dec 2, 2022

@pytorchbot label ciflow/binaries_wheel

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Dec 2, 2022

Can't add following labels to PR: ciflow/binaries_wheel Please ping one of the reviewers for help.

@syed-ahmed syed-ahmed mentioned this pull request Dec 2, 2022
Closed
@kit1980 kit1980 added ciflow/trunk Trigger trunk jobs on your pull request and removed ciflow/trunk Trigger trunk jobs on your pull request labels Dec 3, 2022
kit1980
kit1980 suggested changes Dec 3, 2022
View reviewed changes
kit1980
kit1980 suggested changes Dec 3, 2022
View reviewed changes
kit1980
kit1980 suggested changes Dec 3, 2022
View reviewed changes
@syed-ahmed syed-ahmed requested review from kit1980 and removed request for malfet December 3, 2022 02:26
@atalman atalman added ciflow/binaries Trigger all binary build and upload jobs on the PR ciflow/binaries_conda ciflow/binaries_wheel Trigger binary build and upload jobs for wheel on the PR labels Dec 5, 2022
@syed-ahmed syed-ahmed force-pushed the pypi-cufft branch 2 times, most recently from fbc0fdc to 0179561 Compare December 5, 2022 21:32
atalman
atalman reviewed Dec 6, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@atalman atalman left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks good. However it needs to be merged togeather with builder change. Before merging all the temporary strings needs to be removed and replaced with correct ones.

Also we will need to run some smoke tests on this package before merging the changes.

@atalman atalman added ciflow/binaries Trigger all binary build and upload jobs on the PR ciflow/binaries_conda ciflow/binaries_wheel Trigger binary build and upload jobs for wheel on the PR and removed ciflow/binaries Trigger all binary build and upload jobs on the PR ciflow/binaries_conda ciflow/binaries_wheel Trigger binary build and upload jobs for wheel on the PR labels Dec 19, 2022
@atalman atalman added ciflow/binaries Trigger all binary build and upload jobs on the PR ciflow/binaries_conda ciflow/binaries_wheel Trigger binary build and upload jobs for wheel on the PR and removed ciflow/binaries_conda ciflow/binaries_wheel Trigger binary build and upload jobs for wheel on the PR labels Dec 19, 2022
atalman
atalman approved these changes Jan 4, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@atalman atalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@atalman
Copy link
Copy Markdown
Contributor

atalman commented Jan 4, 2023

@pytorchbot merge

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Jan 4, 2023

This PR needs to be approved by an authorized maintainer before merge.

@atalman
Copy link
Copy Markdown
Contributor

atalman commented Jan 4, 2023

@pytorchbot merge

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Jan 4, 2023

This PR needs to be approved by an authorized maintainer before merge.

@atalman atalman self-requested a review January 4, 2023 15:04
@atalman
Copy link
Copy Markdown
Contributor

atalman commented Jan 4, 2023

@pytorchbot merge -f "CI/CD is green"

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Jan 4, 2023

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@syed-ahmed syed-ahmed mentioned this pull request Feb 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@atalman atalman atalman approved these changes

@kit1980 kit1980 Awaiting requested review from kit1980

Assignees

No one assigned

Labels

ciflow/binaries_wheel Trigger binary build and upload jobs for wheel on the PR ciflow/binaries Trigger all binary build and upload jobs on the PR Merged open source topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CUFFT_INTERNAL_ERROR on RTX 4090

6 participants

@syed-ahmed @atalman @pytorchmergebot @kit1980 @pytorchbot @drisspg