Implement correction argument in torch.masked.{std,var}#87118
Closed
peterbell10 wants to merge 15 commits intogh/peterbell10/446/basefrom
Closed
Implement correction argument in torch.masked.{std,var}#87118peterbell10 wants to merge 15 commits intogh/peterbell10/446/basefrom
peterbell10 wants to merge 15 commits intogh/peterbell10/446/basefrom
Conversation
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/87118
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 1 PendingAs of commit 2f85a57: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Oct 17, 2022
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
This makes the signature of `torch.masked.std` and `var` more consistent with the global namespace variant and also updates the sample inputs to repurpose the existing `sample_inputs_std_var` inputs which fully exercise the `correction` argument. [ghstack-poisoned]
…orch.masked.{std,var}"
This makes the signature of `torch.masked.std` and `var` more consistent with the global namespace variant and also updates the sample inputs to repurpose the existing `sample_inputs_std_var` inputs which fully exercise the `correction` argument.
[ghstack-poisoned]
…orch.masked.{std,var}"
This makes the signature of `torch.masked.std` and `var` more consistent with the global namespace variant and also updates the sample inputs to repurpose the existing `sample_inputs_std_var` inputs which fully exercise the `correction` argument.
[ghstack-poisoned]
This makes the signature of `torch.masked.std` and `var` more consistent with the global namespace variant and also updates the sample inputs to repurpose the existing `sample_inputs_std_var` inputs which fully exercise the `correction` argument. [ghstack-poisoned]
This makes the signature of `torch.masked.std` and `var` more consistent with the global namespace variant and also updates the sample inputs to repurpose the existing `sample_inputs_std_var` inputs which fully exercise the `correction` argument. [ghstack-poisoned]
This makes the signature of `torch.masked.std` and `var` more consistent with the global namespace variant and also updates the sample inputs to repurpose the existing `sample_inputs_std_var` inputs which fully exercise the `correction` argument. [ghstack-poisoned]
cpuhrsch
approved these changes
Nov 3, 2022
peterbell10
added a commit
to peterbell10/pytorch
that referenced
this pull request
Nov 3, 2022
ghstack-source-id: 241c388 Pull Request resolved: pytorch#87118
This makes the signature of `torch.masked.std` and `var` more consistent with the global namespace variant and also updates the sample inputs to repurpose the existing `sample_inputs_std_var` inputs which fully exercise the `correction` argument. [ghstack-poisoned]
This makes the signature of `torch.masked.std` and `var` more consistent with the global namespace variant and also updates the sample inputs to repurpose the existing `sample_inputs_std_var` inputs which fully exercise the `correction` argument. [ghstack-poisoned]
This makes the signature of `torch.masked.std` and `var` more consistent with the global namespace variant and also updates the sample inputs to repurpose the existing `sample_inputs_std_var` inputs which fully exercise the `correction` argument. [ghstack-poisoned]
Contributor
|
@peterbell10 should we merge this? |
Collaborator
Author
|
@kit1980 this will need to merged at the same time as the previous PR in the sack because the tests compare it against the non-masked variant. AFAIK there's no reason they can't both be merged right now though. |
Contributor
I see both are approved, feel free to merge when ready. |
Collaborator
Author
|
@kit1980 this has to be merged by someone from Meta because of #56398 (comment). |
This makes the signature of `torch.masked.std` and `var` more consistent with the global namespace variant and also updates the sample inputs to repurpose the existing `sample_inputs_std_var` inputs which fully exercise the `correction` argument. [ghstack-poisoned]
peterbell10
added a commit
to peterbell10/pytorch
that referenced
this pull request
Dec 7, 2022
ghstack-source-id: fb538c4 Pull Request resolved: pytorch#87118
peterbell10
added a commit
to peterbell10/pytorch
that referenced
this pull request
Dec 7, 2022
ghstack-source-id: fb538c4 Pull Request resolved: pytorch#87118
This makes the signature of `torch.masked.std` and `var` more consistent with the global namespace variant and also updates the sample inputs to repurpose the existing `sample_inputs_std_var` inputs which fully exercise the `correction` argument. [ghstack-poisoned]
Collaborator
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
kulinseth
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Dec 10, 2022
This makes the signature of `torch.masked.std` and `var` more consistent with the global namespace variant and also updates the sample inputs to repurpose the existing `sample_inputs_std_var` inputs which fully exercise the `correction` argument. Pull Request resolved: pytorch#87118 Approved by: https://github.com/cpuhrsch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
correctionvalue andunbiasedargument #55679This makes the signature of
torch.masked.stdandvarmore consistent with the global namespace variant and also updates the sample inputs to repurpose the existingsample_inputs_std_varinputs which fully exercise thecorrectionargument.cc @mlazos @soumith @voznesenskym @yanboliang @penguinwu @anijain2305 @EikanWang @jgong5 @Guobing-Chen @chunyuan-w @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @desertfire