std/var: Deprecate default correction value and unbiased argument#55679
Closed
peterbell10 wants to merge 57 commits intogh/peterbell10/58/basefrom
Closed
std/var: Deprecate default correction value and unbiased argument#55679peterbell10 wants to merge 57 commits intogh/peterbell10/58/basefrom
correction value and unbiased argument#55679peterbell10 wants to merge 57 commits intogh/peterbell10/58/basefrom
Conversation
[ghstack-poisoned]
Contributor
🔗 Helpful links
❌ 9 New FailuresAs of commit 888dcb3 (more details on the Dr. CI page): Expand to see more
🕵️ 9 new failures recognized by patternsThe following CI failures do not appear to be due to upstream breakages
|
This was referenced Apr 9, 2021
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
…d` argument" The default correction value of 1 is incompatible with the array api which defaults to 0 correction. So, we should deprecate the existing default as the first step in changing the default without introducing a silent BC-break. This also deprecates the unbiased overloads entirely, since it for better consistency with the array API. [ghstack-poisoned]
…tion` value and `unbiased` argument" The default correction value of 1 is incompatible with the array api which defaults to 0 correction. So, we should deprecate the existing default as the first step in changing the default without introducing a silent BC-break. This also deprecates the unbiased overloads entirely, since it for better consistency with the array API. [ghstack-poisoned]
…tion` value and `unbiased` argument" The default correction value of 1 is incompatible with the array api which defaults to 0 correction. So, we should deprecate the existing default as the first step in changing the default without introducing a silent BC-break. This also deprecates the unbiased overloads entirely, since it for better consistency with the array API. [ghstack-poisoned]
…d` argument" The default correction value of 1 is incompatible with the array api which defaults to 0 correction. So, we should deprecate the existing default as the first step in changing the default without introducing a silent BC-break. This also deprecates the unbiased overloads entirely, since it for better consistency with the array API. [ghstack-poisoned]
…d` argument" The default correction value of 1 is incompatible with the array api which defaults to 0 correction. So, we should deprecate the existing default as the first step in changing the default without introducing a silent BC-break. This also deprecates the unbiased overloads entirely, since it for better consistency with the array API. [ghstack-poisoned]
…d` argument" The default correction value of 1 is incompatible with the array api which defaults to 0 correction. So, we should deprecate the existing default as the first step in changing the default without introducing a silent BC-break. This also deprecates the unbiased overloads entirely, since it for better consistency with the array API. [ghstack-poisoned]
…d` argument" The default correction value of 1 is incompatible with the array api which defaults to 0 correction. So, we should deprecate the existing default as the first step in changing the default without introducing a silent BC-break. This also deprecates the unbiased overloads entirely, since it for better consistency with the array API. [ghstack-poisoned]
…d` argument" The default correction value of 1 is incompatible with the array api which defaults to 0 correction. So, we should deprecate the existing default as the first step in changing the default without introducing a silent BC-break. This also deprecates the unbiased overloads entirely, since it for better consistency with the array API. [ghstack-poisoned]
…d` argument" The default correction value of 1 is incompatible with the array api which defaults to 0 correction. So, we should deprecate the existing default as the first step in changing the default without introducing a silent BC-break. This also deprecates the unbiased overloads entirely, since it for better consistency with the array API. [ghstack-poisoned]
peterbell10
added a commit
to peterbell10/pytorch
that referenced
this pull request
Dec 7, 2022
The default correction value of 1 is incompatible with the array api which defaults to 0 correction. So, we should deprecate the existing default as the first step in changing the default without introducing a silent BC-break. This also deprecates the unbiased overloads entirely, since it for better consistency with the array API. ghstack-source-id: 955bfe6 Pull Request resolved: pytorch#55679
peterbell10
added a commit
to peterbell10/pytorch
that referenced
this pull request
Dec 7, 2022
The default correction value of 1 is incompatible with the array api which defaults to 0 correction. So, we should deprecate the existing default as the first step in changing the default without introducing a silent BC-break. This also deprecates the unbiased overloads entirely, since it for better consistency with the array API. ghstack-source-id: 955bfe6 Pull Request resolved: pytorch#55679
…d` argument" The default correction value of 1 is incompatible with the array api which defaults to 0 correction. So, we should deprecate the existing default as the first step in changing the default without introducing a silent BC-break. This also deprecates the unbiased overloads entirely, since it for better consistency with the array API. [ghstack-poisoned]
Contributor
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
Contributor
|
No one has reviewed this, and the original author has removed stale and added no-stale, even though there has been no activity in more than a year. |
Collaborator
Author
|
Closing as the deprecation isn't going ahead, see #50010 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
correctionvalue andunbiasedargument #55679The default correction value of 1 is incompatible with the array api
which defaults to 0 correction. So, we should deprecate the existing
default as the first step in changing the default without introducing
a silent BC-break.
This also deprecates the unbiased overloads entirely,
for better consistency with the array API.