Skip to content

[ONNX] Fix pad Circular Mode#86984

Closed
titaiwangms wants to merge 2 commits intogh/AllenTiTaiWang/13/basefrom
gh/AllenTiTaiWang/13/head
Closed

[ONNX] Fix pad Circular Mode#86984
titaiwangms wants to merge 2 commits intogh/AllenTiTaiWang/13/basefrom
gh/AllenTiTaiWang/13/head

Conversation

@titaiwangms
Copy link
Collaborator

@titaiwangms titaiwangms commented Oct 14, 2022

Stack from ghstack (oldest at bottom):

In #73433, a ONNX test case is missed, and the result is incorrect when it is converted to ONNX.

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 14, 2022

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/86984

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 27aec03:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: onnx torch.onnx related changes that should show up in the release notes label Oct 14, 2022
titaiwangms added a commit that referenced this pull request Oct 14, 2022
ghstack-source-id: b5bebd1
Pull Request resolved: #86984
@titaiwangms titaiwangms added module: onnx Related to torch.onnx topic: bug fixes topic category labels Oct 14, 2022
)


@_onnx_symbolic("aten::_pad_circular")
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I deleted this, as this function is actually a subfunction of "aten::pad"

@titaiwangms
Copy link
Collaborator Author

@BowenBao PTAL

Copy link
Collaborator

@BowenBao BowenBao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 25, 2022
@titaiwangms
Copy link
Collaborator Author

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a rebase job. Check the current status here

In #73433, a ONNX test case is missed, and the result is incorrect when it is converted to ONNX.

[ghstack-poisoned]
@pytorchmergebot
Copy link
Collaborator

Successfully rebased gh/AllenTiTaiWang/13/orig onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/86984)

pytorchmergebot pushed a commit that referenced this pull request Oct 25, 2022
ghstack-source-id: 4247085
Pull Request resolved: #86984
@titaiwangms
Copy link
Collaborator Author

@pytorchbot merge -g

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks on your PR pass since you used the green (-g) flag (ETA: 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Nov 5, 2022
In pytorch#73433, a ONNX test case is missed, and the result is incorrect when it is converted to ONNX.
Pull Request resolved: pytorch#86984
Approved by: https://github.com/BowenBao
kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Dec 10, 2022
In pytorch#73433, a ONNX test case is missed, and the result is incorrect when it is converted to ONNX.
Pull Request resolved: pytorch#86984
Approved by: https://github.com/BowenBao
@facebook-github-bot facebook-github-bot deleted the gh/AllenTiTaiWang/13/head branch June 8, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged module: onnx Related to torch.onnx open source release notes: onnx torch.onnx related changes that should show up in the release notes topic: bug fixes topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Circular padding has incorrent implementaion in ONNX module

4 participants