Remove F.pad python implementation#73433
Closed
peterbell10 wants to merge 18 commits intogh/peterbell10/280/basefrom
Closed
Remove F.pad python implementation#73433peterbell10 wants to merge 18 commits intogh/peterbell10/280/basefrom
peterbell10 wants to merge 18 commits intogh/peterbell10/280/basefrom
Conversation
[ghstack-poisoned]
CI Flow Status⚛️ CI FlowRuleset - Version:
|
This was referenced Feb 25, 2022
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 9c1f15d (more details on the Dr. CI page): Expand to see more💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
Closes #73401 [ghstack-poisoned]
Closes #73401 [ghstack-poisoned]
Closes #73401 [ghstack-poisoned]
Closes #73401 [ghstack-poisoned]
peterbell10
added a commit
to peterbell10/pytorch
that referenced
this pull request
Mar 31, 2022
ghstack-source-id: 3f5b1dd Pull Request resolved: pytorch#73433
Closes #73401 [ghstack-poisoned]
jbschlosser
approved these changes
Apr 21, 2022
Contributor
jbschlosser
left a comment
There was a problem hiding this comment.
Beautiful, good riddance to the python impl
Collaborator
Author
|
@pytorchbot merge this |
Contributor
|
Hey @peterbell10. |
Contributor
|
@pytorchbot revert this Reverting this entire stack as it's breaking slow tests |
Collaborator
|
Don't want to revert based on edited command |
Contributor
|
This PR is likely to have broken TorchVision. See pytorch/vision#5873 for details. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 26, 2022
Summary: Pull Request resolved: #73433 Approved by: https://github.com/albanD, https://github.com/jbschlosser Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/cb37e7a080e17edc6d417a0a3d731fe526cfc801 Reviewed By: seemethere, osalpekar Differential Revision: D35874474 fbshipit-source-id: 2e5809865223a72a2c157e5a40e566246db65bd6
frank-wei
pushed a commit
to pytorch/TensorRT
that referenced
this pull request
Jun 4, 2022
Summary: Pull Request resolved: https://github.com/pytorch/fx2trt/pull/65 pytorch/pytorch#73433 changes the default argument value of `value` in functional.pad from `0` to `None` which breaks fx2trt tests. Reviewed By: frank-wei, wushirong Differential Revision: D36076942 fbshipit-source-id: f6f6f869deb106e90b484fc07574790c0b6df46e
This was referenced Oct 14, 2022
pytorchmergebot
pushed a commit
that referenced
this pull request
Oct 25, 2022
In #73433, a ONNX test case is missed, and the result is incorrect when it is converted to ONNX. [ghstack-poisoned]
pytorchmergebot
pushed a commit
that referenced
this pull request
Oct 25, 2022
In #73433, a ONNX test case is missed, and the result is incorrect when it is converted to ONNX. [ghstack-poisoned]
pytorchmergebot
pushed a commit
that referenced
this pull request
Oct 25, 2022
In #73433, a ONNX test case is missed, and the result is incorrect when it is converted to ONNX. Pull Request resolved: #86984 Approved by: https://github.com/BowenBao
kulinseth
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Nov 5, 2022
In pytorch#73433, a ONNX test case is missed, and the result is incorrect when it is converted to ONNX. Pull Request resolved: pytorch#86984 Approved by: https://github.com/BowenBao
kulinseth
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Dec 10, 2022
In pytorch#73433, a ONNX test case is missed, and the result is incorrect when it is converted to ONNX. Pull Request resolved: pytorch#86984 Approved by: https://github.com/BowenBao
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Closes #73401